Re: [PATCH] Fix OOPS in mmap_region() when merging adjacent VM_LOCKED file segments

Randy Dunlap
2009-01-30T16:50:39Z

Linus Torvalds wrote:
>
> On Fri, 30 Jan 2009, Peter Zijlstra wrote:
>>> + vma = vma_merge(mm, prev, addr, addr + len, vm_flags, NULL, file, pgoff, NULL);
>>> + if (vma)
>>> + goto out;
>> You've made checkpatch unhappy ;-)
>
> Yeah, we need to fix that piece of crud.
>
> checkpatch, that is.

It's just advisory, fwiw.

> I think "git grep" is more important than the "ooh, I have a tiny d*ck,
> everybody else should have one too" argument against larger terminals.

and fix the Documentation/CodingStyle recommendations?

--
~Randy