From: Tejun Heo <tj@kernel.org>
To: jeff@garzik.org, linux-ide@vger.kernel.org,
jens.axboe@oracle.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org,
James.Bottomley@HansenPartnership.com, Mauelshagen@RedHat.com,
dm-devel@RedHat.com
Subject: [PATCH 2/3] dmraid: add alt_size to dev_info
Date: Sun, 01 Feb 2009 12:00:36 +0900 [thread overview]
Message-ID: <49851054.10605@kernel.org> (raw)
In-Reply-To: <49851012.8070904@kernel.org>
Add alt_size to dev_info and set it during device scanning if
available.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
include/dmraid/metadata.h | 1 +
lib/device/scan.c | 51 ++++++++++++++++++++++++++++++++------------
2 files changed, 38 insertions(+), 14 deletions(-)
diff --git a/include/dmraid/metadata.h b/include/dmraid/metadata.h
index 91bd221..538043e 100644
--- a/include/dmraid/metadata.h
+++ b/include/dmraid/metadata.h
@@ -120,6 +120,7 @@ struct dev_info {
char *path; /* Actual device node path. */
char *serial; /* ATA/SCSI serial number. */
uint64_t sectors; /* Device size. */
+ uint64_t alt_sectors; /* Alternative device size. (BIOS size) */
};
/* Metadata areas and size stored on a RAID device. */
diff --git a/lib/device/scan.c b/lib/device/scan.c
index e9618c2..3befb08 100644
--- a/lib/device/scan.c
+++ b/lib/device/scan.c
@@ -233,29 +233,52 @@ sysfs_get_size(struct lib_context *lc, struct dev_info *di,
{
int ret = 0;
char buf[22], *sysfs_file;
- const char *sysfs_size = "size";
+ const char *sysfs_size = "size", *sysfs_alt_size = "alt_size";
FILE *f;
if (!(sysfs_file = dbg_malloc(strlen(path) + strlen(name) +
- strlen(sysfs_size) + 3)))
+ max(strlen(sysfs_size),
+ strlen(sysfs_alt_size)) + 3)))
return log_alloc_err(lc, __func__);
+ /* read size */
sprintf(sysfs_file, "%s/%s/%s", path, name, sysfs_size);
- if ((f = fopen(sysfs_file, "r"))) {
- /* Use fread+sscanf for klibc compatibility. */
- if (fread(buf, sizeof(char), sizeof buf - 1, f) &&
- (ret = sscanf(buf, "%" PRIu64, &di->sectors)) != 1) {
- ret = 0;
- log_err(lc, "reading disk size for %s from sysfs",
- di->path);
- }
-
- fclose(f);
- } else
+ if (!(f = fopen(sysfs_file, "r"))) {
log_err(lc, "opening %s", sysfs_file);
+ goto out;
+ }
- dbg_free(sysfs_file);
+ /* Use fread+sscanf for klibc compatibility. */
+ if (!fread(buf, sizeof(char), sizeof buf - 1, f) ||
+ sscanf(buf, "%" PRIu64, &di->sectors) != 1) {
+ log_err(lc, "reading disk size for %s from sysfs",
+ di->path);
+ goto out;
+ }
+ fclose(f);
+
+ /* read alt_size, missing alt_size isn't an error */
+ sprintf(sysfs_file, "%s/%s/%s", path, name, sysfs_alt_size);
+ if (!(f = fopen(sysfs_file, "r"))) {
+ if (errno == ENOENT)
+ ret = 1;
+ else
+ log_err(lc, "opening %s", sysfs_file);
+ goto out;
+ }
+
+ if (!fread(buf, sizeof(char), sizeof buf - 1, f) ||
+ sscanf(buf, "%" PRIu64, &di->alt_sectors) != 1) {
+ log_err(lc, "reading disk alt size for %s from sysfs",
+ di->path);
+ goto out;
+ }
+ ret = 1;
+out:
+ if (f)
+ fclose(f);
+ dbg_free(sysfs_file);
return ret;
}
--
1.6.0.2
next prev parent reply other threads:[~2009-02-01 3:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 2:55 [PATCHSET] block,scsi,libata: implement alt_size Tejun Heo
2009-02-01 2:55 ` [PATCH 1/3] block: add alt_size Tejun Heo
2009-02-01 2:55 ` [PATCH 2/3] scsi: add scsi_device->alt_capacity Tejun Heo
2009-02-01 2:55 ` [PATCH 3/3] libata: export HPA size as alt_size Tejun Heo
2009-02-02 17:12 ` [PATCH] libata: change drive ready wait after hard reset to 5s Stuart_Hayes
2009-02-02 17:17 ` Mario Limonciello
2009-02-09 21:48 ` Stuart_Hayes
2009-02-01 2:59 ` [PATCHSET] dmraid: use alt_size Tejun Heo
2009-02-01 3:00 ` [PATCH 1/3] dmraid: set read_info to @offset by default in read_raid_dev() Tejun Heo
2009-02-01 3:00 ` Tejun Heo [this message]
2009-02-01 3:01 ` [PATCH 3/3] dmraid: make nv use alt_size if available Tejun Heo
2009-02-01 3:20 ` [PATCHSET] block,scsi,libata: implement alt_size Jeff Garzik
2009-02-01 4:14 ` Tejun Heo
2009-04-30 1:13 ` Tejun Heo
2009-04-30 1:45 ` Jeff Garzik
2009-04-30 1:50 ` Tejun Heo
2009-04-30 20:00 ` Jeff Garzik
2009-04-30 21:15 ` Dan Williams
2009-05-04 8:02 ` Tejun Heo
2009-05-04 16:48 ` Dan Williams
2009-05-05 3:28 ` Tejun Heo
2009-05-05 15:34 ` Dan Williams
2009-05-08 9:13 ` Tejun Heo
2009-05-08 16:21 ` Jeff Garzik
2009-05-08 16:23 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49851054.10605@kernel.org \
--to=tj@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Mauelshagen@RedHat.com \
--cc=dm-devel@RedHat.com \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).