From: Dave Young <hidave.darkstar@gmail.com>
To: wgreathouse@smva.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] usb-serial : fix the nousb oops
Date: Sun, 01 Feb 2009 18:53:23 +0800 [thread overview]
Message-ID: <49857F23.3090208@gmail.com> (raw)
In case with "nousb" booting, serial drivers will trigger kernel oops.
Here add usb_disabled() check in usb_serial_init and usb_serial_register
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
drivers/usb/serial/usb-serial.c | 6 ++++++
1 file changed, 6 insertions(+)
diff -uprN a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
--- a/drivers/usb/serial/usb-serial.c 2009-02-01 13:11:11.000000000 +0800
+++ b/drivers/usb/serial/usb-serial.c 2009-02-01 13:24:32.000000000 +0800
@@ -1113,6 +1113,9 @@ static int __init usb_serial_init(void)
int i;
int result;
+ if (usb_disabled())
+ return -ENODEV;
+
usb_serial_tty_driver = alloc_tty_driver(SERIAL_TTY_MINORS);
if (!usb_serial_tty_driver)
return -ENOMEM;
@@ -1230,6 +1233,9 @@ int usb_serial_register(struct usb_seria
/* must be called with BKL held */
int retval;
+ if (usb_disabled())
+ return -ENODEV;
+
fixup_generic(driver);
if (!driver->description)
next reply other threads:[~2009-02-01 10:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 10:53 Dave Young [this message]
2009-02-01 15:51 ` [PATCH 1/2] usb-serial : fix the nousb oops Greg KH
2009-02-02 1:43 ` Dave Young
2009-02-02 10:11 ` Dave Young
2009-02-03 23:58 ` Greg KH
2009-02-04 1:10 ` Dave Young
2009-02-04 23:59 ` Greg KH
2009-02-05 9:33 ` Dave Young
2009-02-06 2:16 ` Dave Young
2009-02-04 8:12 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49857F23.3090208@gmail.com \
--to=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wgreathouse@smva.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox