From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759830AbcHYQJC (ORCPT ); Thu, 25 Aug 2016 12:09:02 -0400 Received: from mout.web.de ([212.227.15.14]:56333 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbcHYQIv (ORCPT ); Thu, 25 Aug 2016 12:08:51 -0400 To: linux-arm-kernel@lists.infradead.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Subject: [PATCH] ARM: pxa: Use kmalloc_array() in pxa_pm_init() Message-ID: <49864e7d-f786-9739-6d8c-4480ce228830@users.sourceforge.net> Date: Thu, 25 Aug 2016 18:07:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:7rVRCxGcAJCojmmG0RilvkIfgf+rYR6SU56DsV9kesG4rMKgrCz 6aK1pgU7I0tolnkDXOzNico4luEiilkfqj8HaPMpTiS34e7LbrK7EP/iSWO11/XIf7TmnuZ 34caxwAIQ1vsAeN7Xu4OZZQVv58b+NX38D4LDCVVQ+UfjG0zTrD+gZ9FFey+7NbX8MfFEMb 432xBdG40yldXuLaZRkug== X-UI-Out-Filterresults: notjunk:1;V01:K0:A0kv8Zxho8c=:5hU4L1QtVEbIl865VYUe3v g0+9iLSMATzeL2DGG5+Y7pwGHHlql9nKFbATVuxVAvBXYT+v/37EedTRfBeZ9KoxsCKQn1ojs pd39mZj5KvrC/9Iq5aK8mPE4juJMtpyiPWhWEq/tMbwYhUUFSW0JQFvMm4enrnNgVT46VMmwv NheowhrsUH/xwBlzzFCO46rguF0KJPTnGr93LD9nDf+9/qKOOqpPqPioPEEyCrsDddk6DE3SZ LKE9nDNtr8lVIJwR5lzg55I/M+A74KfjakYh2ogaeWxNZRhEgsrqGvE1a78ths258AZfM5MDZ l3rIXctY01QUfjBPzOcvgQOvVP+03b77UfGde7Ak+/008CSxLLSJNfMjz1+Zn1r8GWUr2bCiT BKuuw3EMLa7cHoM2ptjbFeU9MjPWuY0ENhk7D2+sBROAC0xXmrZBOKZynHBPDqzqP0XctXNsw l9x9tMzuW0krWU45wFelhkgLbH/ZTPOofiBXB7qPgwfPQe0icHQs9W2afdY5XvR1dxQcutgGr Tuv/AeZnlWxLT2C68/pnp0a5MUH9g599TjP7rr0nAXQge8Ui7N5j2ErFFELr2DKoSAMr1E9Au edcwrWLyXXvoB1YUQk17d3sjDqRVZZ2neJgcuHvIkU4pgyDGaRe0MIIqIvgxuDpQWyBk7WRsw 2m+9jmiIUqtkzcuB1Ept0x7Bz27cxM1QU1GqqkvNczv3C6Ak34ynm9+IKX8njLY30+enPIpIn F7j/zYfPP5WS07cT0r86wzwMfoGVo0pI5sseodM4vwzhyfZFmE4iYdgOs32HWTA9Hxfth/Jup AY20en4VfYzzQHqXTCMP/QoFV40Dg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 25 Aug 2016 18:01:37 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/arm/mach-pxa/pm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-pxa/pm.c b/arch/arm/mach-pxa/pm.c index 388463b..e7450fb 100644 --- a/arch/arm/mach-pxa/pm.c +++ b/arch/arm/mach-pxa/pm.c @@ -104,8 +104,9 @@ static int __init pxa_pm_init(void) return -EINVAL; } - sleep_save = kmalloc(pxa_cpu_pm_fns->save_count * sizeof(unsigned long), - GFP_KERNEL); + sleep_save = kmalloc_array(pxa_cpu_pm_fns->save_count, + sizeof(*sleep_save), + GFP_KERNEL); if (!sleep_save) { printk(KERN_ERR "failed to alloc memory for pm save\n"); return -ENOMEM; -- 2.9.3