[PATCH] Fix the warning of uninitialized value in driver/serial/8250.c

[PATCH] Fix the warning of uninitialized value in driver/serial/8250.c

[Wenji Huang]

This patch is to remove the the warning of uninitialized i in 
driver/serial/8250.c

Signed-off-by: Wenji Huang <wenji.huang@oracle.com>

diff -Nurh drivers/serial/8250.c.Orig drivers/serial/8250.c
--- drivers/serial/8250.c.Orig  2009-02-02 14:02:47.000000000 -0500
+++ drivers/serial/8250.c       2009-02-02 14:03:30.000000000 -0500
@@ -1678,7 +1678,7 @@

  static void serial_unlink_irq_chain(struct uart_8250_port *up)
  {
-       struct irq_info *i;
+       struct irq_info *i = NULL;
         struct hlist_node *n;
         struct hlist_head *h;

Re: [PATCH] Fix the warning of uninitialized value in driver/serial/8250.c

[Laurent Pinchart]

[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]

On Monday 02 February 2009 10:10:06 Wenji Huang wrote:
> This patch is to remove the the warning of uninitialized i in
> driver/serial/8250.c
>
> Signed-off-by: Wenji Huang <wenji.huang@oracle.com>
>
> diff -Nurh drivers/serial/8250.c.Orig drivers/serial/8250.c
> --- drivers/serial/8250.c.Orig  2009-02-02 14:02:47.000000000 -0500
> +++ drivers/serial/8250.c       2009-02-02 14:03:30.000000000 -0500
> @@ -1678,7 +1678,7 @@
>
>   static void serial_unlink_irq_chain(struct uart_8250_port *up)
>   {
> -       struct irq_info *i;
> +       struct irq_info *i = NULL;
>          struct hlist_node *n;
>          struct hlist_head *h;

gcc is wrong, i can't be used uninitialized in that function. You should use 
the following construct instead to suppress the warning without generating any 
code.

	struct irq_info *uninitialized_var(i);

Best regards,

-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussee de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] Fix the warning of uninitialized value in driver/serial/8250.c

[Alan Cox]

> gcc is wrong, i can't be used uninitialized in that function. You should use 
> the following construct instead to suppress the warning without generating any 
> code.

No need for that either - newer gcc gets it right.

Re: [PATCH] Fix the warning of uninitialized value in driver/serial/8250.c

[Alan Cox]

On Mon, 02 Feb 2009 17:10:06 +0800
Wenji Huang <wenji.huang@oracle.com> wrote:

> This patch is to remove the the warning of uninitialized i in 
> driver/serial/8250.c
> 
> Signed-off-by: Wenji Huang <wenji.huang@oracle.com>

NAK - your gcc is wrong. Use a newer gcc and the warning goes away.