From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757457AbZBBR13 (ORCPT ); Mon, 2 Feb 2009 12:27:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752846AbZBBR1S (ORCPT ); Mon, 2 Feb 2009 12:27:18 -0500 Received: from ausxipps301.us.dell.com ([143.166.148.223]:13555 "EHLO ausxipps301.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752551AbZBBR1R (ORCPT ); Mon, 2 Feb 2009 12:27:17 -0500 X-Greylist: delayed 571 seconds by postgrey-1.27 at vger.kernel.org; Mon, 02 Feb 2009 12:27:17 EST Message-ID: <49872AB9.1010807@dell.com> Date: Mon, 02 Feb 2009 11:17:45 -0600 From: Mario Limonciello User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: "Hayes, Stuart" CC: jeff@garzik.org, linux-scsi@vger.kernel.org, James.Bottomley@HansenPartnership.com, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH] libata: change drive ready wait after hard reset to 5s References: <1233456951-992-1-git-send-email-tj@kernel.org> <1233456951-992-4-git-send-email-tj@kernel.org> In-Reply-To: X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig4287E325EF1638B221A646D9" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4287E325EF1638B221A646D9 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable I believe this is the reference that Stuart refers to in the ATA-6 spec: http://www.t10.org/t13/project/d1410r3a-ATA-ATAPI-6.pdf Here's the snippet, (p327): " Transition D0HR1:D0HR1: When the sample indicates that DASP- is negated and less than 450 ms have elapsed since the negation of RESET-, then the device shall make a transition to the D0HR1: Sample_DASP- state. When the sample indicates that DASP- is negated and greater than 450 ms but less than 5 s have elapsed since the negation of RESET-, then the device may make a transition to the D0HR1: Sample_DASP- state. Transition D0HR1:D0HR3: When the sample indicates that DASP- is negated and 5 s have elapsed since the negation of RESET-, then the device shall clear bit 7 in the Error register and make a transition to the D0HR3: Set_status state. When the sample indicates that DASP- is negated and greater than 450 ms but less than 5 s have elapsed since the negation of RESET-, then the device may clear bit 7 in the Error register and make a transition to the D0HR3: Set_status state. " Hayes, Stuart wrote: > This fixes problems during resume with drives that take longer than 1s > to be ready. The ATA-6 spec appears to allow 5 seconds for a drive to > be ready. > > On one affected system, this patch changes "PM: resume devices took..."= > message from 17 seconds to 4 seconds, and gets rid of a lot of ugly > timeout/error messages. > > Without this patch, the libata code moves on after 1s, tries to send a > soft reset (which the drive doesn't see because it isn't ready) which > also times out, then an IDENTIFY command is sent to the drive which > times out, and finally the error handler will try to send another hard > reset which will finally get things working. > > Sorry to send as an attachment, but my mail server will wrap text. > > > Signed-off-by: Stuart Hayes > > =20 --=20 Mario Limonciello *Dell | Linux Engineering* mario_limonciello@dell.com --------------enig4287E325EF1638B221A646D9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkmHKrkACgkQ2CrZjkA73Ys11ACeM9ibnvpj5ZZVyYhE7oHNqikJ 4h4An0zmAdshbCGkcyEjZi9wvGNNkleR =8xrR -----END PGP SIGNATURE----- --------------enig4287E325EF1638B221A646D9--