[GIT PULL] UWB and WUSB fixes

[GIT PULL] UWB and WUSB fixes

[David Vrabel]

This handful of changes fix a number of oopses and other serious bugs
when using devices that don't quite behave as expected.

The following changes since commit 45c82b5a770be66845687a7d027c8b52946d59af:
  Linus Torvalds (1):
        Merge branch 'header-fixes-for-linus' of
git://git.kernel.org/.../tip/linux-2.6-tip

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/dvrabel/uwb.git for-upstream

David Vrabel (7):
      uwb: safely remove all reservations
      wusb: return -ENOTCONN when resetting a port with no connected device
      wusb: timeout when waiting for ASL/PZL updates in whci-hcd
      uwb: lock rc->rsvs_lock with spin_lock_bh()

Huang Weiyi (1):
      uwb: remove unused #include <version.h>'s

 drivers/usb/host/whci/asl.c       |    9 +++++++--
 drivers/usb/host/whci/hw.c        |   15 +++++++++++++++
 drivers/usb/host/whci/pzl.c       |    9 +++++++--
 drivers/usb/host/whci/whcd.h      |    1 +
 drivers/usb/wusbcore/devconnect.c |    1 +
 drivers/usb/wusbcore/rh.c         |    3 +++
 drivers/uwb/allocator.c           |    1 -
 drivers/uwb/drp.c                 |    4 ++--
 drivers/uwb/rsv.c                 |   21 +++++++++++++++------
 9 files changed, 51 insertions(+), 13 deletions(-)

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/

Re: [GIT PULL] UWB and WUSB fixes

[Greg KH]

On Mon, Feb 02, 2009 at 06:06:42PM +0000, David Vrabel wrote:
>  drivers/usb/host/whci/asl.c       |    9 +++++++--
>  drivers/usb/host/whci/hw.c        |   15 +++++++++++++++
>  drivers/usb/host/whci/pzl.c       |    9 +++++++--
>  drivers/usb/host/whci/whcd.h      |    1 +
>  drivers/usb/wusbcore/devconnect.c |    1 +
>  drivers/usb/wusbcore/rh.c         |    3 +++

For patches under drivers/usb/ could you please route them through me?
It makes things a bit easier to coordinate at times.  Not that there is
a problem at all with these patches, but in the future it would be
nicer.

thanks,

greg k-h

Re: [GIT PULL] UWB and WUSB fixes

[David Vrabel]

Greg KH wrote:
> On Mon, Feb 02, 2009 at 06:06:42PM +0000, David Vrabel wrote:
>>  drivers/usb/host/whci/asl.c       |    9 +++++++--
>>  drivers/usb/host/whci/hw.c        |   15 +++++++++++++++
>>  drivers/usb/host/whci/pzl.c       |    9 +++++++--
>>  drivers/usb/host/whci/whcd.h      |    1 +
>>  drivers/usb/wusbcore/devconnect.c |    1 +
>>  drivers/usb/wusbcore/rh.c         |    3 +++
> 
> For patches under drivers/usb/ could you please route them through me?
> It makes things a bit easier to coordinate at times.  Not that there is
> a problem at all with these patches, but in the future it would be
> nicer.

This is more work for me (and you) and I don't see the benefit.  Could
you expand on what situations you see this as helping?

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/

Re: [GIT PULL] UWB and WUSB fixes

[Greg KH]

On Tue, Feb 03, 2009 at 02:14:17PM +0000, David Vrabel wrote:
> Greg KH wrote:
> > On Mon, Feb 02, 2009 at 06:06:42PM +0000, David Vrabel wrote:
> >>  drivers/usb/host/whci/asl.c       |    9 +++++++--
> >>  drivers/usb/host/whci/hw.c        |   15 +++++++++++++++
> >>  drivers/usb/host/whci/pzl.c       |    9 +++++++--
> >>  drivers/usb/host/whci/whcd.h      |    1 +
> >>  drivers/usb/wusbcore/devconnect.c |    1 +
> >>  drivers/usb/wusbcore/rh.c         |    3 +++
> > 
> > For patches under drivers/usb/ could you please route them through me?
> > It makes things a bit easier to coordinate at times.  Not that there is
> > a problem at all with these patches, but in the future it would be
> > nicer.
> 
> This is more work for me (and you) and I don't see the benefit.  Could
> you expand on what situations you see this as helping?

I carry changes to drivers/usb/host all the time that can affect whci
due to changes in the USB hcd interface.  Also, people end up sending me
patches for these files for things like header file cleanups and other
minor stuff.

So that can potentially conflict with stuff you are doing without the
my knowledge.

Also, it would be good to have the linux-usb developers at least review
any changes to these files, myself included, right?

It shouldn't be any more work for you, just send the patches to me and
forget about them, I'll queue them up at the proper time :)

thanks,

greg k-h

Re: [GIT PULL] UWB and WUSB fixes

[David Vrabel]

Greg KH wrote:
> 
> Also, it would be good to have the linux-usb developers at least review
> any changes to these files, myself included, right?

I'll post patches to the list if I think they're significant enough to
need a review.

> It shouldn't be any more work for you, just send the patches to me and
> forget about them, I'll queue them up at the proper time :)

To be honest, in the past you have been too slow to handle patches and
review in a timely manner.  The current system of sending pull request
direct to Linus has worked well so I'm going to stick with it for now.

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/

Re: [GIT PULL] UWB and WUSB fixes

[Greg KH]

On Mon, Feb 16, 2009 at 02:57:54PM +0000, David Vrabel wrote:
> Greg KH wrote:
> > 
> > Also, it would be good to have the linux-usb developers at least review
> > any changes to these files, myself included, right?
> 
> I'll post patches to the list if I think they're significant enough to
> need a review.

They should all be posted to the linux-usb list please.

> > It shouldn't be any more work for you, just send the patches to me and
> > forget about them, I'll queue them up at the proper time :)
> 
> To be honest, in the past you have been too slow to handle patches and
> review in a timely manner.  The current system of sending pull request
> direct to Linus has worked well so I'm going to stick with it for now.

Things were slow when we were handling a 30+ patchset full of the whole
wusb system.  Smaller patches get handled within a week, and I've not
had any complaints about that in a while (musb withstanding, but that's
a total mess for other reasons...)

So again, I'd really like at least the ability to review the patches,
which in your current development flow, isn't even possible.

thanks,

greg k-h

Re: [GIT PULL] UWB and WUSB fixes

[David Vrabel]

Greg KH wrote:
> On Mon, Feb 16, 2009 at 02:57:54PM +0000, David Vrabel wrote:
>> Greg KH wrote:
>>> Also, it would be good to have the linux-usb developers at least review
>>> any changes to these files, myself included, right?
>> I'll post patches to the list if I think they're significant enough to
>> need a review.
> 
> They should all be posted to the linux-usb list please.

Okay.

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/