From: Jeff Garzik <jeff@garzik.org>
To: "Pasi Kärkkäinen" <pasik@iki.fi>
Cc: linux-kernel@vger.kernel.org,
Linux IDE mailing list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] Fix sata_sil compilation error with libata debug enabled (2.6.29-rcX)
Date: Mon, 02 Feb 2009 22:38:43 -0500 [thread overview]
Message-ID: <4987BC43.3040400@garzik.org> (raw)
In-Reply-To: <20090202194714.GN15052@edu.joroinen.fi>
Pasi Kärkkäinen wrote:
> Hello!
>
> I tried compiling 2.6.29-rc1 and 2.6.29-rc3 with libata debugging enabled
> and got the following error:
>
> CC [M] drivers/ata/sata_sil.o
> drivers/ata/sata_sil.c: In function 'sil_fill_sg':
> drivers/ata/sata_sil.c:327: error: 'pi' undeclared (first use in this function)
> drivers/ata/sata_sil.c:327: error: (Each undeclared identifier is reported only once
> drivers/ata/sata_sil.c:327: error: for each function it appears in.)
> make[2]: *** [drivers/ata/sata_sil.o] Error 1
> make[1]: *** [drivers/ata] Error 2
> make: *** [drivers] Error 2
>
> include/linux/libata.h has the following enabled:
>
> #define ATA_DEBUG
> #define ATA_VERBOSE_DEBUG
> #define ATA_IRQ_TRAP
>
> The attached patch fixes the compilation.. I'm not sure if it's the correct
> fix, but looking at the code it seems correct.. or at least makes the
> code compile for me :)
applied
next prev parent reply other threads:[~2009-02-03 3:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 19:47 [PATCH] Fix sata_sil compilation error with libata debug enabled (2.6.29-rcX) Pasi Kärkkäinen
2009-02-02 21:12 ` Jeff Garzik
2009-02-03 3:38 ` Jeff Garzik [this message]
2009-02-03 12:01 ` Pasi Kärkkäinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4987BC43.3040400@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pasik@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox