From: Manuel Naranjo <naranjo.manuel@gmail.com>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: wgreathouse@smva.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] usb-serial: fix the aircable_init failure path
Date: Tue, 03 Feb 2009 09:19:22 -0200 [thread overview]
Message-ID: <4988283A.6030300@gmail.com> (raw)
In-Reply-To: <49857F7E.9090708@gmail.com>
Acked-by: Naranjo Manuel Francisco <naranjo.manuel@gmail.com>
> The failure path of aircable_init is wrong, fix the order of (goto) labels.
>
> Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
> ---
> drivers/usb/serial/aircable.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -uprN a/drivers/usb/serial/aircable.c b/drivers/usb/serial/aircable.c
> --- a/drivers/usb/serial/aircable.c 2009-02-01 13:12:35.000000000 +0800
> +++ b/drivers/usb/serial/aircable.c 2009-02-01 13:26:28.000000000 +0800
> @@ -621,9 +621,9 @@ static int __init aircable_init(void)
> goto failed_usb_register;
> return 0;
>
> -failed_serial_register:
> - usb_serial_deregister(&aircable_device);
> failed_usb_register:
> + usb_serial_deregister(&aircable_device);
> +failed_serial_register:
> return retval;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
prev parent reply other threads:[~2009-02-03 11:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 10:54 [PATCH 2/2] usb-serial: fix the aircable_init failure path Dave Young
2009-02-03 11:19 ` Manuel Naranjo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4988283A.6030300@gmail.com \
--to=naranjo.manuel@gmail.com \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wgreathouse@smva.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox