* [PATCH 2/2] usb-serial: fix the aircable_init failure path
@ 2009-02-01 10:54 Dave Young
2009-02-03 11:19 ` Manuel Naranjo
0 siblings, 1 reply; 2+ messages in thread
From: Dave Young @ 2009-02-01 10:54 UTC (permalink / raw)
To: wgreathouse, linux-usb, linux-kernel
The failure path of aircable_init is wrong, fix the order of (goto) labels.
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
drivers/usb/serial/aircable.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -uprN a/drivers/usb/serial/aircable.c b/drivers/usb/serial/aircable.c
--- a/drivers/usb/serial/aircable.c 2009-02-01 13:12:35.000000000 +0800
+++ b/drivers/usb/serial/aircable.c 2009-02-01 13:26:28.000000000 +0800
@@ -621,9 +621,9 @@ static int __init aircable_init(void)
goto failed_usb_register;
return 0;
-failed_serial_register:
- usb_serial_deregister(&aircable_device);
failed_usb_register:
+ usb_serial_deregister(&aircable_device);
+failed_serial_register:
return retval;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] usb-serial: fix the aircable_init failure path
2009-02-01 10:54 [PATCH 2/2] usb-serial: fix the aircable_init failure path Dave Young
@ 2009-02-03 11:19 ` Manuel Naranjo
0 siblings, 0 replies; 2+ messages in thread
From: Manuel Naranjo @ 2009-02-03 11:19 UTC (permalink / raw)
To: Dave Young; +Cc: wgreathouse, linux-usb, linux-kernel
Acked-by: Naranjo Manuel Francisco <naranjo.manuel@gmail.com>
> The failure path of aircable_init is wrong, fix the order of (goto) labels.
>
> Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
> ---
> drivers/usb/serial/aircable.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -uprN a/drivers/usb/serial/aircable.c b/drivers/usb/serial/aircable.c
> --- a/drivers/usb/serial/aircable.c 2009-02-01 13:12:35.000000000 +0800
> +++ b/drivers/usb/serial/aircable.c 2009-02-01 13:26:28.000000000 +0800
> @@ -621,9 +621,9 @@ static int __init aircable_init(void)
> goto failed_usb_register;
> return 0;
>
> -failed_serial_register:
> - usb_serial_deregister(&aircable_device);
> failed_usb_register:
> + usb_serial_deregister(&aircable_device);
> +failed_serial_register:
> return retval;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-03 11:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-01 10:54 [PATCH 2/2] usb-serial: fix the aircable_init failure path Dave Young
2009-02-03 11:19 ` Manuel Naranjo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox