public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Pavel Machek <pavel@suse.cz>
Cc: Zachary Amsden <zach@vmware.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Ingo Molnar <mingo@elte.hu>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC WIP] x86/paravirt: add register-saving thunks to	reduce caller register pressure
Date: Tue, 03 Feb 2009 09:23:12 -0800	[thread overview]
Message-ID: <49887D80.8090708@goop.org> (raw)
In-Reply-To: <20090130210625.GD1253@ucw.cz>

Pavel Machek wrote:
>> This patch seeks to alleviate this pressure by introducing wrapper
>> thunks that will do the register saving/restoring, so that the
>> callsite doesn't need to worry about it, but the callee function can
>> be conventional compiler-generated code.  In many cases (particularly
>> performance-sensitive cases) the callee will be in assembler anyway,
>> and need not use the compiler's calling convention.
>>
>> Standard calling convention is:
>> 	 arguments	    return	scratch
>> x86-32	 eax edx ecx	    eax		?
>>     
>
> esi edi ebp ?
>   

Those are callee-save, so the caller doesn't need to worry about 
preserving their values.

> actually standard calling convention is all arguments on stack iirc
> but we use regparm=3 for kernel...?
>   

Yes.  "standard" = "standard kernel calling convention"


    J

      parent reply	other threads:[~2009-02-03 17:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28 18:14 [PATCH RFC WIP] x86/paravirt: add register-saving thunks to reduce caller register pressure Jeremy Fitzhardinge
2009-01-28 23:05 ` Zachary Amsden
2009-01-28 23:17   ` Jeremy Fitzhardinge
2009-01-28 23:38   ` Jeremy Fitzhardinge
2009-01-30 21:06 ` Pavel Machek
2009-02-03 15:12   ` Ingo Molnar
2009-02-03 17:23   ` Jeremy Fitzhardinge [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49887D80.8090708@goop.org \
    --to=jeremy@goop.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pavel@suse.cz \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox