From: "H. Peter Anvin" <hpa@kernel.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Ingo Molnar <mingo@elte.hu>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Stable Kernel <stable@kernel.org>
Subject: Re: [PATCH] xen: disable interrupts before saving in percpu
Date: Tue, 03 Feb 2009 18:21:49 -0800 [thread overview]
Message-ID: <4988FBBD.9020608@kernel.org> (raw)
In-Reply-To: <4988FA4A.6080002@goop.org>
Jeremy Fitzhardinge wrote:
> H. Peter Anvin wrote:
>> Jeremy Fitzhardinge wrote:
>>
>>> xen_mc_batch has a small preempt race where it takes the address of a
>>> percpu variable immediately before disabling interrupts, thereby
>>> leaving a small window in which we may migrate to another cpu and save
>>> the flags in the wrong percpu variable. Disable interrupts before
>>> saving the old flags in a percpu.
>>>
>>
>> Applied to tip:core/xen, thanks!
>
> Can you push this Linusward too?
>
Just merged into tip:core/urgent, so it should end up in the next set of
pull requests.
-hpa
prev parent reply other threads:[~2009-02-04 2:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 0:01 [PATCH] xen: disable interrupts before saving in percpu Jeremy Fitzhardinge
2009-02-04 1:23 ` H. Peter Anvin
2009-02-04 2:15 ` Jeremy Fitzhardinge
2009-02-04 2:21 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4988FBBD.9020608@kernel.org \
--to=hpa@kernel.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox