From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753892AbZBDO3l (ORCPT ); Wed, 4 Feb 2009 09:29:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752126AbZBDO3c (ORCPT ); Wed, 4 Feb 2009 09:29:32 -0500 Received: from mx2.redhat.com ([66.187.237.31]:51846 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752173AbZBDO3b (ORCPT ); Wed, 4 Feb 2009 09:29:31 -0500 Message-ID: <4989A60E.9000809@redhat.com> Date: Wed, 04 Feb 2009 16:28:30 +0200 From: Avi Kivity User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: Jaswinder Singh Rajput CC: Sam Ravnborg , Ingo Molnar , Jaswinder Singh Rajput , Andrew Morton , x86 maintainers , LKML Subject: Re: [GIT PULL -tip v3] fix 39 'make headers_check' warnings References: <1232287474.3130.19.camel@localhost.localdomain> <20090118185635.GA30514@elte.hu> <497445B6.7030606@redhat.com> <20090119110153.GA8321@uranus.ravnborg.org> <497469AC.2030107@redhat.com> <3f9a31f40901232216r4656776mfac4388485180a60@mail.gmail.com> In-Reply-To: <3f9a31f40901232216r4656776mfac4388485180a60@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jaswinder Singh Rajput wrote: > On Mon, Jan 19, 2009 at 5:23 PM, Avi Kivity wrote: > >> Sam Ravnborg wrote: >> >>>> They are. This bits advertise to userspace what features kvm supports, >>>> both compile- and run-time. >>>> >>>> >>> This is wrong... >>> The headers does not change with the kernel configuration and advertising >>> the >>> kvm features via a .h file like this is simply plain broken. >>> >>> >> Ok. Don't know why I thought unifdef was supplied with the full >> configuration. >> >> >>> You cannot assume that the header files are generated with the exact same >>> config >>> as used by the running kernel. >>> >>> >> This is just for arch specific defines. I'll move these to asm/kvm.h. >> >> >>> And userspace has in no way access to the CONFIG_ namespace which is >>> purely kernel-internal. >>> >>> I cannot see how you have ever seen kcm advertise that for example >>> KVM_CAP_USER_NMI >>> equals to 22 because CONFIG_X86 is never (supposed to be) defined in >>> userspace - >>> except if you did so yourself by some means. >>> >>> >> We did, we ship a hacked-up kvm.h (generated by unifdef) with our userspace. >> >> > > latest -tip is still giving 'make headers_check' warnings: > usr/include/linux/kvm.h:61: leaks CONFIG_X86 to userspace where it is not valid > usr/include/linux/kvm.h:64: leaks CONFIG_X86 to userspace where it is not valid > usr/include/linux/kvm.h:387: leaks CONFIG_X86 to userspace where it > is not valid > usr/include/linux/kvm.h:391: leaks CONFIG_X86 to userspace where it > is not valid > usr/include/linux/kvm.h:396: leaks CONFIG_X86 to userspace where it > is not valid > > So should I resend my patch or you are going to move this stuff > Your patch is broken. I'll push mine shortly. -- error compiling committee.c: too many arguments to function