From: Frank Seidel <fseidel@suse.de>
To: Frans Pop <elendil@planet.nl>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org,
len.brown@intel.com, shaohuhua.li@intel.com,
kristen.c.accardi@intel.com, frank@f-seidel.de
Subject: Re: [PATCH] ACPI: add missing KERN_* constants to printks
Date: Wed, 04 Feb 2009 16:31:11 +0100 [thread overview]
Message-ID: <4989B4BF.6060509@suse.de> (raw)
In-Reply-To: <200902041628.03675.elendil@planet.nl>
Frans Pop wrote:
> This patch looks broken to me, at least for some of your changes.
> For example, in the bit quoted above all printks together make up
> *one single* message, which means that only the _first_ of the
> printks should have the KERN_* prefix. printks that are continuations
> should not have the prefix.
Are you absolutely sure about that? The janitors todo lets me guess
they should aswell me prefixed.
Otherwise yes, then some of the changes wouldn't be needed.
Thanks,
Frank
next prev parent reply other threads:[~2009-02-04 15:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 14:34 [PATCH] ACPI: add missing KERN_* constants to printks Frank Seidel
2009-02-04 15:28 ` Frans Pop
2009-02-04 15:31 ` Frank Seidel [this message]
2009-02-04 15:44 ` Geert Uytterhoeven
2009-02-04 15:48 ` Frank Seidel
2009-02-04 16:12 ` Frans Pop
2009-02-04 16:48 ` Geert Uytterhoeven
2009-02-04 16:03 ` [PATCHv2] " Frank Seidel
2009-02-07 5:38 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4989B4BF.6060509@suse.de \
--to=fseidel@suse.de \
--cc=akpm@linux-foundation.org \
--cc=elendil@planet.nl \
--cc=frank@f-seidel.de \
--cc=kristen.c.accardi@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=shaohuhua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox