From: Frank Seidel <fseidel@suse.de>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Frans Pop <elendil@planet.nl>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org,
len.brown@intel.com, shaohuhua.li@intel.com,
kristen.c.accardi@intel.com, frank@f-seidel.de
Subject: Re: [PATCH] ACPI: add missing KERN_* constants to printks
Date: Wed, 04 Feb 2009 16:48:58 +0100 [thread overview]
Message-ID: <4989B8EA.5000105@suse.de> (raw)
In-Reply-To: <alpine.LRH.2.00.0902041642450.7690@vixen.sonytel.be>
Geert Uytterhoeven wrote:
> Actually they should, but the right prefix :-)
>
> Quoting include/linux/kernel.h:
> ...
Ah, no i see. And i missed the line (from janitors todo) that
this should only be done for line beginnings (and now KERN_CONT
for core/arch..).
Thank you very much that pointer. Will keep it in mind for my
further cleanups of this topic.
Of course i will then also redo the above patch.
Thanks,
Frank
next prev parent reply other threads:[~2009-02-04 15:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 14:34 [PATCH] ACPI: add missing KERN_* constants to printks Frank Seidel
2009-02-04 15:28 ` Frans Pop
2009-02-04 15:31 ` Frank Seidel
2009-02-04 15:44 ` Geert Uytterhoeven
2009-02-04 15:48 ` Frank Seidel [this message]
2009-02-04 16:12 ` Frans Pop
2009-02-04 16:48 ` Geert Uytterhoeven
2009-02-04 16:03 ` [PATCHv2] " Frank Seidel
2009-02-07 5:38 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4989B8EA.5000105@suse.de \
--to=fseidel@suse.de \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=akpm@linux-foundation.org \
--cc=elendil@planet.nl \
--cc=frank@f-seidel.de \
--cc=kristen.c.accardi@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=shaohuhua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox