Re: mmotm 2009-02-03-19-43 uploaded (cirrusfb)

Re: mmotm 2009-02-03-19-43 uploaded (cirrusfb)

[Randy Dunlap]

akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2009-02-03-19-43 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/
> 
> and will soon be available at
> 
>    git://git.zen-sources.org/zen/mmotm.git
> 
> It contains the following patches against 2.6.29-rc3:

> cirrusfb-convert-printks-to-dev_foo.patch

-	DPRINTK("\n");
+	dev_dbg(info->device, "\n");


drivers/video/cirrusfb.c:2397: error: 'info' undeclared (first use in this function)


Did you build test this??

-- 
~Randy

Re: mmotm 2009-02-03-19-43 uploaded (cirrusfb)

[Andrew Morton]

On Wed, 04 Feb 2009 09:28:57 -0800
Randy Dunlap <randy.dunlap@oracle.com> wrote:

> akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2009-02-03-19-43 has been uploaded to
> > 
> >    http://userweb.kernel.org/~akpm/mmotm/
> > 
> > and will soon be available at
> > 
> >    git://git.zen-sources.org/zen/mmotm.git
> > 
> > It contains the following patches against 2.6.29-rc3:
> 
> > cirrusfb-convert-printks-to-dev_foo.patch
> 
> -	DPRINTK("\n");
> +	dev_dbg(info->device, "\n");

Actually

		dev_dbg(info->device,
			"cirrusfb_setup: option '%s'\n", this_opt);

> 
> drivers/video/cirrusfb.c:2397: error: 'info' undeclared (first use in this function)
> 
> 
> Did you build test this??

As a module - that code is inside #ifdef MODULE.

I did the easy fix ;)

--- a/drivers/video/cirrusfb.c~cirrusfb-convert-printks-to-dev_foo-fix-fix2
+++ a/drivers/video/cirrusfb.c
@@ -2384,7 +2384,8 @@ static int __init cirrusfb_init(void)
 }
 
 #ifndef MODULE
-static int __init cirrusfb_setup(char *options) {
+static int __init cirrusfb_setup(char *options)
+{
 	char *this_opt;
 
 	if (!options || !*options)
@@ -2394,9 +2395,6 @@ static int __init cirrusfb_setup(char *o
 		if (!*this_opt)
 			continue;
 
-		dev_dbg(info->device,
-			"cirrusfb_setup: option '%s'\n", this_opt);
-
 		if (!strcmp(this_opt, "noaccel"))
 			noaccel = 1;
 		else if (!strncmp(this_opt, "mode:", 5))
_