From: Tejun Heo <tj@kernel.org>
To: Cliff Wickman <cpw@sgi.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [PATCH v2] x86: UV uv_flush_tlb_others WARN_ON
Date: Thu, 05 Feb 2009 14:57:39 +0900 [thread overview]
Message-ID: <498A7FD3.5030900@kernel.org> (raw)
In-Reply-To: <E1LU7sT-0004ZT-9G@eag09.americas.sgi.com>
Cliff Wickman wrote:
> From: Cliff Wickman <cpw@sgi.com>
>
> uv_flush_tlb_others() (arch/x86/kernel/tlb_uv.c)
> The "WARN_ON(!in_atomic())" fails if CONFIG_PREEMPT is not enabled.
> And CONFIG_PREEMPT is not enabled by default in the distribution that
> most UV owners will use.
>
> We could #ifdef CONFIG_PREEMPT the warning, but that is not good form.
>
> And there seems to be no suitable fix to in_atomic() when CONFIG_PREMPT
> is not on.
> As you commented, Ingo:
> > and we have no proper primitive to test for atomicity. (mainly
> > because we dont know about atomicity on a non-preempt kernel)
>
> I propose that we drop the WARN_ON.
>
> Diffed against 2.6.29-rc2
>
> Signed-off-by: Cliff Wickman <cpw@sgi.com>
Heh.. I included it in the first two merges but forgot it in the final
round. Applying to tj-percpu.
Thanks.
--
tejun
next prev parent reply other threads:[~2009-02-05 5:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 23:06 [PATCH v2] x86: UV uv_flush_tlb_others WARN_ON Cliff Wickman
2009-02-05 5:57 ` Tejun Heo [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-03-06 23:30 Cliff Wickman
2009-03-07 5:53 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498A7FD3.5030900@kernel.org \
--to=tj@kernel.org \
--cc=cpw@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox