From: Frank Seidel <fseidel@suse.de>
To: linux kernel <linux-kernel@vger.kernel.org>
Cc: linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org,
greg@kroah.com, kristen.c.accardi@intel.com, ashok.raj@intel.com,
shaohua.li@intel.com, anil.s.keshavamurthy@intel.com,
fenghua.yu@intel.com, akpm@linux-foundation.org,
frank@f-seidel.de, Frans Pop <elendil@planet.nl>,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Subject: [PATCHv2] PCI: add missing KERN_* constants to printks
Date: Thu, 05 Feb 2009 19:02:52 +0100 [thread overview]
Message-ID: <498B29CC.2030000@suse.de> (raw)
In-Reply-To: <498B2116.6010707@suse.de>
From: Frank Seidel <frank@f-seidel.de>
According to kerneljanitors todo list all printk calls (beginning
a new line) should have an according KERN_* constant.
Those are the missing pieces here for the pci subsystem.
Signed-off-by: Frank Seidel <frank@f-seidel.de>
---
drivers/pci/hotplug/pciehp.h | 3 ++-
drivers/pci/hotplug/shpchp.h | 3 ++-
drivers/pci/intel-iommu.c | 2 +-
3 files changed, 5 insertions(+), 3 deletions(-)
--- a/drivers/pci/intel-iommu.c
+++ b/drivers/pci/intel-iommu.c
@@ -1960,7 +1960,7 @@ static inline void iommu_prepare_isa(voi
ret = iommu_prepare_identity_map(pdev, 0, 16*1024*1024);
if (ret)
- printk("IOMMU: Failed to create 0-64M identity map, "
+ printk(KERN_ERR "IOMMU: Failed to create 0-64M identity map, "
"floppy might not work\n");
}
--- a/drivers/pci/hotplug/pciehp.h
+++ b/drivers/pci/hotplug/pciehp.h
@@ -48,7 +48,8 @@ extern struct workqueue_struct *pciehp_w
#define dbg(format, arg...) \
do { \
if (pciehp_debug) \
- printk("%s: " format, MY_NAME , ## arg); \
+ printk(KERN_DEBUG "%s: " format, MY_NAME , \
+ ## arg); \
} while (0)
#define err(format, arg...) \
printk(KERN_ERR "%s: " format, MY_NAME , ## arg)
--- a/drivers/pci/hotplug/shpchp.h
+++ b/drivers/pci/hotplug/shpchp.h
@@ -50,7 +50,8 @@ extern struct workqueue_struct *shpchp_w
#define dbg(format, arg...) \
do { \
if (shpchp_debug) \
- printk("%s: " format, MY_NAME , ## arg); \
+ printk(KERN_DEBUG "%s: " format, MY_NAME , \
+ ## arg); \
} while (0)
#define err(format, arg...) \
printk(KERN_ERR "%s: " format, MY_NAME , ## arg)
next prev parent reply other threads:[~2009-02-05 18:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 17:25 [PATCH] PCI: add missing KERN_* constants to printks Frank Seidel
2009-02-05 17:28 ` Greg KH
2009-02-05 17:32 ` Frank Seidel
2009-02-05 17:36 ` Frank Seidel
2009-02-05 17:49 ` Greg KH
2009-02-05 18:01 ` Frank Seidel
2009-02-05 18:02 ` Frank Seidel [this message]
2009-02-06 8:04 ` [PATCHv2] " Kenji Kaneshige
2009-02-06 8:07 ` Frank Seidel
2009-02-06 8:57 ` Kenji Kaneshige
2009-02-06 9:01 ` Taku Izumi
2009-02-06 9:16 ` Frank Seidel
2009-02-06 10:23 ` Geert Uytterhoeven
2009-02-06 9:23 ` [PATCHv3] " Frank Seidel
2009-02-09 6:47 ` Kenji Kaneshige
2009-02-13 21:16 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498B29CC.2030000@suse.de \
--to=fseidel@suse.de \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=akpm@linux-foundation.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=ashok.raj@intel.com \
--cc=elendil@planet.nl \
--cc=fenghua.yu@intel.com \
--cc=frank@f-seidel.de \
--cc=greg@kroah.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox