From: Ben Greear <greearb@candelatech.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <yinghai@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
len.brown@intel.com
Subject: Re: PATCH: Allow over-ride of smp_found_cfg with kernel cmd-line option.
Date: Thu, 05 Feb 2009 12:45:05 -0800 [thread overview]
Message-ID: <498B4FD1.9000804@candelatech.com> (raw)
In-Reply-To: <20090205195832.GD3129@elte.hu>
Ingo Molnar wrote:
> I'd _much_ rather have a warning message printed and have a default,
> unconditional fallback to mptable parsing in this case.
>
> I.e. same end result just no ugly and inconvenient force_smp_found_cfg.
>
> The mptable works fine in most such cases to enumerate apic details. (as it
> does in your case, evidently)
>
> And if both the ACPI and the MPTABLE is hosed on a box, it cannot be of much
> use on other OSs either, right?
>
> So please do a patch that removes the 'smp_found_config' and which changes
> the warning message to warn about no ACPI table in the MADT table. Ok?
That is fine with me, but I know next to zero about the deep logic
of this code. I'd be worried that Len put in the change to fix something
more critical than my problem on my particular board.
If no one argues otherwise, I'll get a patch together & tested this evening.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2009-02-05 20:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 19:46 PATCH: Allow over-ride of smp_found_cfg with kernel cmd-line option Ben Greear
2009-02-05 19:52 ` Randy Dunlap
2009-02-05 19:58 ` Ingo Molnar
2009-02-05 20:45 ` Ben Greear [this message]
2009-02-06 19:21 ` PATCH: (v2) " Ben Greear
2009-02-06 19:30 ` Randy Dunlap
2009-02-06 19:34 ` Yinghai Lu
2009-02-06 20:27 ` PATCH: (v3) " Ben Greear
2009-02-07 2:57 ` Len Brown
2009-02-06 19:31 ` PATCH: " Ingo Molnar
2009-02-07 3:00 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498B4FD1.9000804@candelatech.com \
--to=greearb@candelatech.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox