Re: [PATCH] crypto: add missing KERN_* constants to printks

Alexey Dobriyan
2009-02-06T14:57:26Z

On Fri, Feb 06, 2009 at 03:54:38PM +0100, Frank Seidel wrote:
> Alexey Dobriyan schrieb:
> > On Fri, Feb 06, 2009 at 03:19:10PM +0100, Frank Seidel wrote:
> >> According to kerneljanitors todo list all printk calls (beginning
> >> a new line) should have an according KERN_* constant.
> >
> > Forget about kernel janitors todo list, fix a bug instead.
>
> Sure, i am eager to get my hands dirty in the kernel ;-),
> but i needed to start somewhere and everybody told me
> that the janitors todo list would be good place to start.
>
> >> Those are the missing pieces here for the crypto subsystem.
> >
> > You're inserting KERN_WARNING everywhere, what for?
>
> Because every new line should have KERN_* constant and
> KERN_WARNING is default/doesn't change current printout
> behaviour.

Some messages there were truly debugging and some clearly weren't
WARNING, but INFO.