public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL] x86: unify some of kernel/irq*.c
@ 2009-02-07  0:31 Jeremy Fitzhardinge
  2009-02-09 10:29 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Jeremy Fitzhardinge @ 2009-02-07  0:31 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: the arch/x86 maintainers, Linux Kernel Mailing List, Xen-devel

These changes factor out the differences between 32 and 64-bit do_IRQ 
and unify the rest. Unfortunately there are still quite a few other 
differences (like interrupt stack handling) which preclude further easy 
unification.

Thanks,
    J

The following changes since commit f21daa4d04885a34d1972afa9f82a8aebb6152bb:
  Ingo Molnar (1):
        Merge branch 'out-of-tree'

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git jsgf/x86/unify-irq

Jeremy Fitzhardinge (2):
      x86: add handle_irq() to allow interrupt injection
      x86: unify do_IRQ()

 arch/x86/include/asm/irq.h |    4 +++-
 arch/x86/kernel/irq.c      |   38 ++++++++++++++++++++++++++++++++++++++
 arch/x86/kernel/irq_32.c   |   29 +++++------------------------
 arch/x86/kernel/irq_64.c   |   34 +++++-----------------------------
 4 files changed, 51 insertions(+), 54 deletions(-)



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [GIT PULL] x86: unify some of kernel/irq*.c
  2009-02-07  0:31 [GIT PULL] x86: unify some of kernel/irq*.c Jeremy Fitzhardinge
@ 2009-02-09 10:29 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2009-02-09 10:29 UTC (permalink / raw)
  To: Jeremy Fitzhardinge
  Cc: the arch/x86 maintainers, Linux Kernel Mailing List, Xen-devel


* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> These changes factor out the differences between 32 and 64-bit do_IRQ  
> and unify the rest. Unfortunately there are still quite a few other  
> differences (like interrupt stack handling) which preclude further easy  
> unification.
>
> Thanks,
>    J
>
> The following changes since commit f21daa4d04885a34d1972afa9f82a8aebb6152bb:
>  Ingo Molnar (1):
>        Merge branch 'out-of-tree'
>
> are available in the git repository at:
>
>  git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git jsgf/x86/unify-irq
>
> Jeremy Fitzhardinge (2):
>      x86: add handle_irq() to allow interrupt injection

Why doesnt Xen use a special irqchip, instead of this private hook/layer
in the lowlevel x86 arch level?

irqchip is at least well-specified and widely used. do_IRQ() internals
on the other hand will become a Xen special quickly. Also, adding a
needless function call there obviously does not help native performance.

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-02-09 10:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-07  0:31 [GIT PULL] x86: unify some of kernel/irq*.c Jeremy Fitzhardinge
2009-02-09 10:29 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox