public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mariusz Ceier <mceier@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: David Brownell <david-b@pacbell.net>,
	spi-devel-general@lists.sourceforge.net,
	lkml <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] spi: limit reaches -1, tested 0
Date: Sun, 08 Feb 2009 18:42:17 +0100	[thread overview]
Message-ID: <498F1979.1030104@gmail.com> (raw)
In-Reply-To: <498F0D64.4040909@gmail.com>

Roel Kluin writes in first post:
> -			while ((read(drv_data) == 0) && limit--);
> +			while ((read(drv_data) == 0) && --limit);

Roel Kluin writes in last post:
> -			while ((read(drv_data) == 0) && limit--);
> +			while ((read(drv_data) == 0) && limit--)
> +				cpu_relax();

so should there be postfix or prefix decrement ? :)

Mariusz Ceier



  parent reply	other threads:[~2009-02-08 17:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-08 14:18 [PATCH] spi: limit reaches -1, tested 0 Roel Kluin
2009-02-08 15:55 ` David Brownell
2009-02-08 16:28   ` David Brownell
2009-02-08 16:50     ` Roel Kluin
2009-02-08 17:26       ` David Brownell
2009-02-08 17:42       ` Mariusz Ceier [this message]
2009-02-08 17:46         ` Roel Kluin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498F1979.1030104@gmail.com \
    --to=mceier@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roel.kluin@gmail.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox