public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org,
	linux-kernel@vger.kernel.org, rjw@sisk.pl
Subject: Re: [PATCH] libata-sff: fix 32-bit PIO regression
Date: Mon, 09 Feb 2009 01:10:59 +0300	[thread overview]
Message-ID: <498F5873.1080906@ru.mvista.com> (raw)
In-Reply-To: <20090208201125.49326bd2@lxorguk.ukuu.org.uk>

Hello.

Alan Cox wrote:

>> swapping bytes to and fro as well by using io*_rep() which shouldn't byte-swap.
>>     
>
> Nice - thats a very sneaky and clean way to do it but probably should be
> commented or someone will "optimise" it one day ..
>   

   OK, I'll recast and repost it -- along with the patch cleaning up the 
corresponding fragment of the 16-bit I/O method.

MBR, Sergei



  reply	other threads:[~2009-02-08 22:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-08 19:53 [PATCH] libata-sff: fix 32-bit PIO regression Sergei Shtylyov
2009-02-08 20:11 ` Alan Cox
2009-02-08 22:10   ` Sergei Shtylyov [this message]
2009-02-08 21:12 ` Hugh Dickins
2009-02-08 22:18   ` Sergei Shtylyov
2009-02-08 23:48     ` Mikael Pettersson
2009-02-09  0:03       ` Sergei Shtylyov
2009-02-09  0:19         ` Jeff Garzik
2009-02-09 10:43           ` Sergei Shtylyov
2009-02-09 10:56             ` Sergei Shtylyov
2009-02-09  0:07   ` Sergei Shtylyov
2009-02-09 10:22     ` Hugh Dickins
2009-02-09 16:42       ` Sergei Shtylyov
2009-02-09 16:48         ` Sergei Shtylyov
2009-02-09 18:14           ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498F5873.1080906@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox