From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@linux.intel.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] PCI/MSI: fix msi_mask()
Date: Mon, 09 Feb 2009 10:38:20 +0900 [thread overview]
Message-ID: <498F890C.2030300@jp.fujitsu.com> (raw)
In-Reply-To: <20090208112650.GD31509@parisc-linux.org>
Matthew Wilcox wrote:
> On Thu, Feb 05, 2009 at 11:47:36AM +0900, Hidetoshi Seto wrote:
>> This patch fix the wrong array in the msi_mask().
>
> Quite correct. While disconnected for a couple of weeks, I also
> considered this possible fix:
>
> static inline __attribute_const__ u32 msi_mask(unsigned x)
> {
> /* Don't shift by >= width of type */
> if (x >= 5)
> return 0xffffffff;
> return (1 << (1 << x)) - 1;
> }
>
> which has the added bonus of not running off the end of the array if
> some device has a bogus value in its config space.
>
> What do you think?
Yeah, I think it's better one.
I'm going to post a revised patch hiring this style.
Thanks,
H.Seto
next prev parent reply other threads:[~2009-02-09 1:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 2:47 [PATCH] PCI/MSI: fix msi_mask() Hidetoshi Seto
2009-02-08 11:26 ` Matthew Wilcox
2009-02-09 1:38 ` Hidetoshi Seto [this message]
2009-02-09 1:40 ` [PATCH] PCI/MSI: fix msi_mask() (rev. 2) Hidetoshi Seto
2009-02-09 3:27 ` Matthew Wilcox
2009-02-09 4:31 ` Hidetoshi Seto
2009-02-09 17:23 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498F890C.2030300@jp.fujitsu.com \
--to=seto.hidetoshi@jp.fujitsu.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox