Re: [PATCH -v3] futex: fix reference leak

Ingo Molnar
2009-02-11T16:26:52Z

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Wed, 2009-02-11 at 16:49 +0100, Ingo Molnar wrote:
> > * Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > > So you prefer this version?
> >
> > yes, with s/out_unlock_put_key/err_unlock_put_key. That's the
> > only error path that goes via the tail of the function, correct?
>
> Right, but I think one can argue that most of the out* jumps are errors.
>
> The only non-error return is the !unqueue_me() case.
>
> Also, since there's only one user of out_unlock_put_key, we might also
> do this:

yeah. Also mark it via unlikely().

Ingo