From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753325AbZBIV5X (ORCPT ); Mon, 9 Feb 2009 16:57:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752668AbZBIV5I (ORCPT ); Mon, 9 Feb 2009 16:57:08 -0500 Received: from acsinet12.oracle.com ([141.146.126.234]:17857 "EHLO acsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752317AbZBIV5H (ORCPT ); Mon, 9 Feb 2009 16:57:07 -0500 Message-ID: <4990A6A2.90107@oracle.com> Date: Mon, 09 Feb 2009 13:56:50 -0800 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: Mike Frysinger CC: Randy Dunlap , James Morris , Mimi Zohar , LKML , Serge Hallyn Subject: Re: ima changes to shmem breaks !CONFIG_SHMEM References: <8bd0f97a0902090830y11965ayc436fc1157510764@mail.gmail.com> <8bd0f97a0902091327m3a71bf4ex46a391436481032d@mail.gmail.com> <4990A4ED.7020901@oracle.com> <8bd0f97a0902091351p4a719809gf1f2119735f0430f@mail.gmail.com> In-Reply-To: <8bd0f97a0902091351p4a719809gf1f2119735f0430f@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: acsmt703.oracle.com [141.146.40.81] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A09020B.4990A68D.006B:SCFSTAT928724,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mike Frysinger wrote: > On Mon, Feb 9, 2009 at 16:49, Randy Dunlap wrote: >> Mike Frysinger wrote: >>> On Mon, Feb 9, 2009 at 16:23, James Morris wrote: >>>> On Mon, 9 Feb 2009, Mike Frysinger wrote: >>>>> commit 1df9f0a73178718969ae47d813b8e7aab2cf073c broke default building >>>>> for Blackfin systems: >>>>> CC mm/shmem.o >>>>> mm/shmem.c: In function 'shmem_zero_setup': >>>>> mm/shmem.c:2670: error: implicit declaration of function 'ima_shm_check' >>>>> make[1]: *** [mm/shmem.o] Error 1 >>>>> >>>>> that's because the ima.h include was added behind the CONFIG_SHMEM >>>>> markings rather than everywhere, just like the function is used. >>>> Does this seem like the correct fix? >>> it converts the build error to a build warning: >>> CC mm/shmem.o >>> In file included from mm/shmem.c:32: >>> include/linux/ima.h:25: warning: 'struct linux_binprm' declared inside >>> parameter list >>> include/linux/ima.h:25: warning: its scope is only this definition or >>> declaration, which is probably not what you want >> Add to the other patch: >> >> --- linux-next-20090209.orig/include/linux/ima.h >> +++ linux-next-20090209/include/linux/ima.h >> @@ -8,6 +8,7 @@ >> */ >> >> #include >> +struct linux_binprm; >> >> #ifndef _LINUX_IMA_H >> #define _LINUX_IMA_H >> >> >> >> and it builds for me. > > yes, it builds w/out warnings now for me too. any reason those are > outside of _LINUX_IMA_H ? looks like they should both be inside of > that. Agreed, that change is also good. Thanks. -- ~Randy