From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755984AbZBIWI5 (ORCPT ); Mon, 9 Feb 2009 17:08:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753140AbZBIWIp (ORCPT ); Mon, 9 Feb 2009 17:08:45 -0500 Received: from relay3.sgi.com ([192.48.171.31]:41945 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755485AbZBIWIo (ORCPT ); Mon, 9 Feb 2009 17:08:44 -0500 Message-ID: <4990A96A.3060603@sgi.com> Date: Mon, 09 Feb 2009 14:08:42 -0800 From: Mike Travis User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: Alexey Dobriyan CC: linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: include/linux/irq.h:452: error: implicit declaration of function 'cpu_to_node' References: <20090121215306.GA10123@x200.localdomain> <4977B1F1.1090602@sgi.com> <20090209203502.GA7701@x200.localdomain> <4990A899.8070302@sgi.com> In-Reply-To: <4990A899.8070302@sgi.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mike Travis wrote: > Alexey Dobriyan wrote: >> On Wed, Jan 21, 2009 at 03:38:25PM -0800, Mike Travis wrote: >>> Alexey Dobriyan wrote: >>>> On mips-malta: >>>> >>>> CC arch/mips/mti-malta/malta-int.o >>>> In file included from arch/mips/mti-malta/malta-int.c:25: >>>> include/linux/irq.h: In function 'init_alloc_desc_masks': >>>> include/linux/irq.h:452: error: implicit declaration of function 'cpu_to_node' >>>> include/linux/irq.h:454: error: 'GFP_ATOMIC' undeclared (first use in this function) >>>> >>>> I _think_ init_alloc_desc_masks() should be made out of line to fix this. >>> Hi Alexey, >>> >>> Does adding #include fix the error? If so, I can add this to >>> linux/irq.h. >>> >>> The primary reason it's inline is that unless CONFIG_CPUMASK_OFFSTACK=y, then the >>> entire routine is a NOP which optimizes out more completely as an inline function. >> linux/slab.h helps. > > Hi Alexey, > > Since you reported this problem a similar issue was discovered on s390. However > the fix for that was to include interrupt.h instead of irq.h. > > Could you try this as well? > > Here's a tail end pointer to the thread and Andrew's commit msg including the > patch is below. > > http://marc.info/?l=linux-mm-commits&m=123360349631362&w=4 Sorry, I should have made a patch specific to mips, and here that is... Thanks, Mike --- Subject: mips: include interrupt.h instead of irq.h Impact: fix build error on mips arch Signed-off-by: Mike Travis --- arch/mips/mti-malta/malta-int.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6-linus.orig/arch/mips/mti-malta/malta-int.c +++ linux-2.6-linus/arch/mips/mti-malta/malta-int.c @@ -22,7 +22,7 @@ * with two internal 82C95 interrupt controllers. */ #include -#include +#include #include #include #include