Re: [PATCH 01/11] x86: include correct %gs in a.out core dump

Jeremy Fitzhardinge
2009-02-09T17:13:00Z

Tejun Heo wrote:
> Impact: dump the correct %gs into a.out core dump
>
> aout_dump_thread() read %gs but didn't include it in core dump. Fix
> it.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> arch/x86/include/asm/a.out-core.h | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/include/asm/a.out-core.h b/arch/x86/include/asm/a.out-core.h
> index 3782220..3c601f8 100644
> --- a/arch/x86/include/asm/a.out-core.h
> +++ b/arch/x86/include/asm/a.out-core.h
> @@ -23,8 +23,6 @@
> */
> static inline void aout_dump_thread(struct pt_regs *regs, struct user *dump)
> {
> - u16 gs;
> -
> /* changed the size calculations - should hopefully work better. lbt */
> dump->magic = CMAGIC;
> dump->start_code = 0;
> @@ -57,7 +55,7 @@ static inline void aout_dump_thread(struct pt_regs *regs, struct user *dump)
> dump->regs.ds = (u16)regs->ds;
> dump->regs.es = (u16)regs->es;
> dump->regs.fs = (u16)regs->fs;
> - savesegment(gs, gs);
> + savesegment(gs, dump->regs.gs);
>
Yes, that looks like a bit of mindless auto-conversion.

Acked-by: Jeremy Fitzhardinge <jeremy@goop.org>

J