Re: [PATCH] lis3lv02d: add axes knowledge of HP Pavilion dv5 models

Éric Piel
2009-02-10T10:34:42Z

(putting back the cc's, please keep them when answering)

Palatis Tseng schreef:
> Éric Piel 提到:
>> No problem, the patch from Giuseppe will get the axex fine :-)
>>
>> However, could you let use know if you too, on your laptop, have huge
>> fluctuations even when the laptop is not moving? Could you give an idea
>> of the minimum and maximum values of each axis when the laptop is set
>> normally on the desk without touching it?
>>
>> Thanks,
>> Eric
> I took a look at the patch but my axis on dv5 is Y_inverted (instead of
> X_inverted.) i patched my lis3lv02d.c and added:
>
> === cut here ===
> AXIS_DMI_MATCH("HPDV5", "HP Pavilion dv5", y_inverted),
> === cut here ===
>
> and neverball worked just correct with it so i'm kinda sure my patch
> about the axis should be correct.
>
> i've also tested with x_inverted, but whenever i evaluate the left side
> of my notebook the ball goes to the left side too which is not real-world
> behavier.
>
> mine is a HP Pavilion dv5 1003ax with AMD PUMA platform.
> `dmidecode | grep "Product Name" says:
> (under "System Information"...)
> Product Name: HP Pavilion dv5 Notebook PC
Giuseppe,
Palatis mentions that on his laptop the sensor is actually y_inverted.
Could you check your laptop? In particular it would be nice if you could
describe the values for the four positions defined in the documentation
file. BTW, what is the exact version of your laptop? Is it the same as
Palatis?

Palatis, could you let us know if you also have a lot of "noise" in the
values. That is, if when using jstest /dev/input/js0 you see big changes
in the values. Is it like on Giuseppe's laptop of around 8000?

Moreover I'm wondering if this could be an error on LSB/MSB ordering.
Maybe looking at the raw values (cat
/sys/devices/platform/lis3lv02d/position) would give more insight...

See you,
Eric