From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932085AbcBKNu7 (ORCPT ); Thu, 11 Feb 2016 08:50:59 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:61779 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752954AbcBKNu6 (ORCPT ); Thu, 11 Feb 2016 08:50:58 -0500 From: Arnd Bergmann To: Paul Gortmaker Cc: Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, Eddie Huang , Matthias Brugger , Sascha Hauer , Matt Redfearn , Paul Burton , Jiri Slaby , linux-serial@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] serial: 8250: fix building mediatek with SERIAL_8250=m Date: Thu, 11 Feb 2016 14:49:43 +0100 Message-ID: <4992215.sKvb0IIruL@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160208165535.GZ23093@windriver.com> References: <1454935947-2743255-1-git-send-email-arnd@arndb.de> <20160208165535.GZ23093@windriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:YuZy6YHPBJgtqi6eW1RpfXZoeAenTnjpTGef/OLwn2lauvIqKaa bmrFeD1+xQmg75oPt/VQekexywZVZrTI0WB0Eqwnb2blCJ8/lpY1dwQUOTCUVEF7PsajhJo AhM94pUWQuANE6cLJtEQh1uOriiHLY6Uw5AkQ/oAdKwkk5LfP7GIQuYX/Gn3OzFRD0KGnYB A9H3xSyAmBkH5r0Ad6ODQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:gj/YJMX1iBQ=:/C/zpP1fcMyq8+nWvEQVrs wRZ271pXRPmxrd1J+yMPcVlV5QgWYECL2Pd8nVXbuJJXaPcRjEk3DquxQg8fuGa9nYPUpPAe5 Noth2nAPG4sZOYLoQM/SY2L5Bsff0COw0jJbA01BucxcqRUECi/OX2MSuRaHE2QQwaNMVyYpT c34b9fe2uaow/g4bUXDWh+EvNa9HoNRRv+UKlT/RLYrYYhuk7l7IlUC9oftV+D7o141W4328H UU0nwXI7tcafOtnRUgV/UhUm1vxLfHVXFqj0ycdFeaS0GbaA6niFYkasTJ9UtGagKmZ6YP7w0 MwXFP2ksmE4JmjiE1fuxKCuGn4q5LVHDSqAOIJhHObASvyHAuf84cp7r/rWubNGG9bbZJ2pDP oI6wHBIg7QSfX7qQyub8jhAFBccpOKnMDK60QRRaM4/cPU1e1LG9mc1gl0yJy8Hn53ebN8m69 uad8aJ/FOOeSogb/XYBkIj8AiiAeyXQD+vQBuzmiwMdlGZ8pAuJkulaXmBNgiK0cKGv53lK+5 j/66jzuBWxgMoHGwstt4qhPKDB3w6gbegKALvFypKuQjhV5iEiaEnUYnUZQBHb09JgqrPqbAK MdgUZ4Pb1jWAS3C3L8sV4u4FxWDLdb7jNVBI+4P7sTZfYtNCB4nMnXrwa3YDTNfeB8PT0mjE8 S8TqttSm5M05MLcDitLAs7vpj4F8yu8dBE1G08IJx46LE586TEqrq7ilIPgST4ZxYHrEb3qCD gejFYgMqiuwWNoZM Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 08 February 2016 11:55:35 Paul Gortmaker wrote: > > drivers/tty/built-in.o: In function `mtk8250_set_termios': > > 8250_ingenic.c:(.text+0x1bee8): undefined reference to `serial8250_do_set_termios' > > 8250_ingenic.c:(.text+0x1bf10): undefined reference to `uart_get_baud_rate' > > 8250_ingenic.c:(.text+0x1c09c): undefined reference to `uart_get_divisor' > > drivers/tty/built-in.o: In function `mtk8250_do_pm': > > 8250_ingenic.c:(.text+0x1c0d0): undefined reference to `serial8250_do_pm' > > drivers/tty/built-in.o: In function `mtk8250_probe': > > 8250_ingenic.c:(.text+0x1c2e4): undefined reference to `serial8250_register_8250_port' > > serial/8250/8250_mtk.c:287:242: error: data definition has no type or storage class [-Werror] > > serial/8250/8250_mtk.c:287:122: error: 'mtk8250_platform_driver_init' defined but not used [-Werror=unused-function] > > Probably should drop the ingenic lines above ; assuming they are make -j N > related and that mtk doesn't depend on or build ingenic. I looked at these again and noticed that this is just being misreported by the linker. I don't know exactly what happens here but I see it a lot: the function names ("mtk8250_set_termios") are all correct, but the file names ("8250_ingenic.c") are wrong. I normally edit out the file names manually but forgot that here. I'll fix it up when resending. Arnd