From: "Éric Piel" <Eric.Piel@tremplin-utc.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>,
linux-kernel@vger.kernel.org, pavel@suse.cz
Subject: Re: [PATCHv7] lis3lv02d: support both one- and two-byte sensors
Date: Thu, 12 Feb 2009 00:53:18 +0100 [thread overview]
Message-ID: <499364EE.1030400@tremplin-utc.net> (raw)
In-Reply-To: <20090211143844.27ca0d6c.akpm@linux-foundation.org>
Andrew Morton schreef:
> Also, this comment:
>
> /*
> * The sensor can also generate interrupts (DRDY) but it's pretty pointless
> * because their are generated even if the data do not change. So it's better
> * to keep the interrupt for the free-fall event. The values are updated at
> * 40Hz (at the lowest frequency), but as it can be pretty time consuming on
> * some low processor, we poll the sensor only at 20Hz... enough for the
> * joystick.
> */
>
> seems to be describing something which isn't there.
Actually it's describing the main architecture of the driver, and wa put
at this place due to the two lines just _above_ this comment:
/* joystick device poll interval in milliseconds */
#define MDPS_POLL_INTERVAL 50
A poll of 50 ms = 20Hz. And it's there to explain why I decided to use
polling although in the documentation they say that interrupt can be
generated whenever data is updated. (even if in general it's better to
use interrupt driven than polling based)
Suggestions are welcome to make this comment more understandable :-)
Eric
prev parent reply other threads:[~2009-02-11 23:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 1:04 [PATCHv6] lis3lv02d: support both one- and two-byte sensors Giuseppe Bilotta
2009-02-11 9:47 ` Éric Piel
2009-02-11 10:06 ` [PATCHv7] " Giuseppe Bilotta
2009-02-11 10:17 ` Éric Piel
2009-02-11 22:38 ` Andrew Morton
2009-02-11 22:44 ` Giuseppe Bilotta
2009-02-11 22:53 ` Andrew Morton
2009-02-11 23:06 ` Giuseppe Bilotta
2009-02-11 23:27 ` Andrew Morton
2009-02-11 23:53 ` Éric Piel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499364EE.1030400@tremplin-utc.net \
--to=eric.piel@tremplin-utc.net \
--cc=akpm@linux-foundation.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox