public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-kernel@vger.kernel.org
Subject: Re: get/put unaligned helpers
Date: Thu, 12 Feb 2009 10:50:18 +0200	[thread overview]
Message-ID: <4993E2CA.1070408@panasas.com> (raw)
In-Reply-To: <1234367339.5481.3.camel@brick>

Harvey Harrison wrote:
> On Wed, 2009-02-11 at 15:35 +0100, Christoph Hellwig wrote:
>> I just loked into using the new get/put unaligned helpers.  I must
>> say that I'm really unhappy about the lack of typing there.  We did
>> put all the sparse infrastructure in place to make sure we do have
>> strong typechecking for LE/Be types, but using these helpers defeats
>> that.
>>
>> Can you please make these properly typed?
> 
> Sorry, real life got in the way, I had a series in -mm for a few months
> that did the typing and fixed the argument ordering by providing a
> load/store API and then moving the existing users across, but that got
> delayed while the (aligned) byteswapping patches were made suitable
> for mainline.
> 
> I'll get that series revived shortly.
> 
> Harvey
> 

Speaking of which. When all this is done do you intend to also export
the unaligned.h headers to user-mode just like the aligned Endian helpers?

That could help in a couple of projects, so you have my vote.

Thanks
Boaz

  reply	other threads:[~2009-02-12  8:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 14:35 get/put unaligned helpers Christoph Hellwig
2009-02-11 15:48 ` Harvey Harrison
2009-02-12  8:50   ` Boaz Harrosh [this message]
2009-02-12 12:44     ` Maciej W. Rozycki
2009-02-12 12:55       ` Boaz Harrosh
2009-02-12 14:39         ` Maciej W. Rozycki
2009-02-12 18:43     ` Stefan Richter
2009-02-12 20:20     ` Harvey Harrison
2009-02-13 22:07 ` Harvey Harrison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4993E2CA.1070408@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=harvey.harrison@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox