From: Chandru <chandru@in.ibm.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org,
benh@kernel.crashing.org, chandru@linux.vnet.ibm.com,
paulus@samba.org, akpm@linux-foundation.org
Subject: Re: + powerpc-fix-code-for-reserved-memory-spanning-across-nodes.patch added to -mm tree
Date: Fri, 13 Feb 2009 16:48:46 +0530 [thread overview]
Message-ID: <49955716.3070208@in.ibm.com> (raw)
In-Reply-To: <20090210175915.GA2541@cmpxchg.org>
Johannes Weiner wrote:
>
> This is fine, too. Subtracting physbase yields a smaller reserve_size
> if not page aligned (bootmem will round it up again, no problem there)
> and at the end of the loop, size is not zero. This has no practical
> impacts, though, as far as I can see.
>
> The interesting question, however, is whether this patch actually
> fixes the problem you encountered? If so, I would be glad if we could
> drop the workaround we currently have in -mm.
>
> Hannes
>
Hello Hannes,
Yes, the patch fixes the problem of hitting the BUG_ON()
in bootmem. Andrew removed the workaround from the
-mm tree. Thanks to you for running your eyes on this
issue and arriving at an almost workable patch.
thanks,
Chandru
prev parent reply other threads:[~2009-02-13 11:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200812250806.mBP86LPQ018399@imap1.linux-foundation.org>
2009-02-08 20:47 ` + powerpc-fix-code-for-reserved-memory-spanning-across-nodes.patch added to -mm tree Johannes Weiner
2009-02-09 0:31 ` Benjamin Herrenschmidt
2009-02-10 17:51 ` Dave Hansen
2009-02-10 18:27 ` Chandru
2009-02-13 11:01 ` Chandru
2009-02-10 11:35 ` Chandru
2009-02-10 17:59 ` Johannes Weiner
2009-02-13 11:18 ` Chandru [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49955716.3070208@in.ibm.com \
--to=chandru@in.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=chandru@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox