From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__
Date: Fri, 13 Feb 2009 10:44:47 -0800 [thread overview]
Message-ID: <4995BF9F.2050509@goop.org> (raw)
In-Reply-To: <20090213123721.GA1879@elte.hu>
Ingo Molnar wrote:
> From beb6943d8df7ce9278282101af4e0f6f7b648451 Mon Sep 17 00:00:00 2001
> From: Ingo Molnar <mingo@elte.hu>
> Date: Fri, 13 Feb 2009 13:36:47 +0100
> Subject: [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__
>
I think this is wrong in principle. There should never be a reason to
include a non-_types.h into asm.
(Fine as a build fix, of course.)
J
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
> arch/x86/include/asm/page_32.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/include/asm/page_32.h b/arch/x86/include/asm/page_32.h
> index b3f0bf7..da4e762 100644
> --- a/arch/x86/include/asm/page_32.h
> +++ b/arch/x86/include/asm/page_32.h
> @@ -3,6 +3,8 @@
>
> #include <asm/page_32_types.h>
>
> +#ifndef __ASSEMBLY__
> +
> #ifdef CONFIG_HUGETLB_PAGE
> #define HAVE_ARCH_HUGETLB_UNMAPPED_AREA
> #endif
> @@ -19,8 +21,6 @@ extern unsigned long __phys_addr(unsigned long);
> #define pfn_valid(pfn) ((pfn) < max_mapnr)
> #endif /* CONFIG_FLATMEM */
>
> -#ifndef __ASSEMBLY__
> -
> #ifdef CONFIG_X86_USE_3DNOW
> #include <asm/mmx.h>
>
>
>
next prev parent reply other threads:[~2009-02-13 18:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 23:23 [GIT PULL] clean header untangling Jeremy Fitzhardinge
2009-02-13 12:02 ` Ingo Molnar
2009-02-13 12:18 ` [PATCH] x86 headers: remove duplicate pud_large() definition Ingo Molnar
2009-02-13 12:23 ` [PATCH] x86 headers: include linux/types.h Ingo Molnar
2009-02-13 12:27 ` Ingo Molnar
2009-02-13 12:37 ` [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__ Ingo Molnar
2009-02-13 18:44 ` Jeremy Fitzhardinge [this message]
2009-02-13 18:49 ` Ingo Molnar
2009-02-13 18:52 ` Jeremy Fitzhardinge
2009-02-13 18:57 ` Ingo Molnar
2009-02-13 16:25 ` [PATCH] x86 headers: include linux/types.h Jeremy Fitzhardinge
2009-02-13 18:09 ` Ingo Molnar
2009-02-16 21:00 ` Jeremy Fitzhardinge
2009-02-13 18:52 ` Jeremy Fitzhardinge
2009-02-13 18:55 ` Ingo Molnar
2009-02-13 18:59 ` Jeremy Fitzhardinge
2009-02-13 20:05 ` Ingo Molnar
2009-02-13 18:57 ` Jaswinder Singh Rajput
2009-02-13 16:27 ` [PATCH] x86 headers: remove duplicate pud_large() definition Jeremy Fitzhardinge
2009-02-13 18:02 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4995BF9F.2050509@goop.org \
--to=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox