From: "H. Peter Anvin" <hpa@zytor.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i386 pci: Handle mmaping 64bit bars.
Date: Fri, 13 Feb 2009 22:17:13 -0800 [thread overview]
Message-ID: <499661E9.3070809@zytor.com> (raw)
In-Reply-To: <m1vdrdveis.fsf@fess.ebiederm.org>
Eric W. Biederman wrote:
> While reading through pci_mmap_page_range I realized that if don't
> properly handle 64bit bars in the 32bit kernel.
>
> Without the added cast the shift will be done in 32bit despite being
> assigned to a 64bit variable and if we are mmaping an address above
> 4G things will do the wrong thing.
Hm... this really should be resource_size_t, no?
> - u64 addr = vma->vm_pgoff << PAGE_SHIFT;
> + u64 addr = ((u64)vma->vm_pgoff) << PAGE_SHIFT;
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-02-14 6:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 4:16 [PATCH] i386 pci: Handle mmaping 64bit bars Eric W. Biederman
2009-02-14 6:17 ` H. Peter Anvin [this message]
2009-02-14 7:09 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499661E9.3070809@zytor.com \
--to=hpa@zytor.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox