Re: [RFC 0/6] x86 tip asm ENTRY,ENDPROC cleanup

["H. Peter Anvin" <hpa@zytor.com>]

Alexander van Heukelum wrote:
> 
> Hi Peter,
> 
> I see. But that would be new behaviour. I would propose to use
> completely separate macro's to handle frame-setup code generation,
> and keep ENTRY/GLOBAL/END/ENDPROC only for setting metadata and
> alignment. I think it's worth it to spell out code-generating
> macro's explicitly: there are not that many asm functions, and
> quite a few of them would need special handling. I think noone
> wants to see an ENDPROC_NOFRAMETEARDOWN ;).
> 
> The common-case example would look like this.
> 
> GLOBAL(c_callable_function)
>         ENTER
>         [asm-code]
>         LEAVE
>         ret
> ENDPROC(c_callable_function)
> 

I guess I'm a bit concerned about people omitting them, but it's equally
concerning that people use the wrong macros, so yes, it's probably the
better thing in the long run.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.