From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752525AbbJKTOf (ORCPT <rfc822;w@1wt.eu>);
	Sun, 11 Oct 2015 15:14:35 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:62185 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751726AbbJKTOb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 11 Oct 2015 15:14:31 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: ygardi@codeaurora.org
Cc: james.bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org,
        subhashj@codeaurora.org, gbroner@codeaurora.org, draviv@codeaurora.org,
        Noa Rubens <noag@codeaurora.org>,
        Raviv Shvili <rshvili@codeaurora.org>,
        Vinayak Holikatti <vinholikatti@gmail.com>,
        "James E.J. Bottomley" <jbottomley@odin.com>,
        "open list:ABI/API" <linux-api@vger.kernel.org>
Subject: Re: [PATCH v3] scsi: ufs: add ioctl interface for query request
Date: Sun, 11 Oct 2015 21:14:22 +0200
Message-ID: <4997819.aH6H7EmMIs@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <96a76c637a4772997c149276632ed80d.squirrel@www.codeaurora.org>
References: <1444302569-30740-1-git-send-email-ygardi@codeaurora.org> <5970981.84uI3QIcdF@wuerfel> <96a76c637a4772997c149276632ed80d.squirrel@www.codeaurora.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:402zV5Y1upeQFSr3NO70D8hgKlIfZfng1oCUKTtSg49/16bgIwL
 wAb7yL8q24oOohi8pNgDOYDG25GXS8E/Xb8a5x1CuQCsLmhnxh5KB1t9Q6c2qGuAfZQccGh
 s59oXQcv5nz5oS7dx1eR7mDOQVVSajKqZ0s+OpN8A4wdWfpjL9ZcPNsorE+V2p9SNO6zmVe
 lDrMc0QfsShkupU/g4g1g==
X-UI-Out-Filterresults: notjunk:1;V01:K0:nQnPVuMGqlU=:nXd6nsIeNsEFJK2oJ9u1Ve
 G4TQws2mgHmXSlKpkljSfPaBq/aoF7NwbPBjjhLTL2q3aOkBLRIL5jBhWu4mUW5WK6fbLmXyM
 sJaRkoT70fjXzelhAoIAL9+zCZp/mgEaf9vcrXjC408kxNJ2IRWK/yWh9Oz0xIIagcegYE1C2
 f/0uSxMDgG4IrXgJ3GTSW9jvYIISVh0vQ+w2CqeFOXvPU2axNcGQvvD/jH2Pz35HynSBGUSX/
 SqnUfxtkoMI2pMWn95wTtjxOrbiFr96JQ2YOaePChEkjxF+GGvWmyyHm4IJokEK7Pw9Jyc7PM
 5xCKVUmBftJ712cFzi/AILpBiOKgq+zh6LVaaG75IIM8lnur8rh8mtIyXNDvtHPpjgwsqs14b
 8anaW1itiUlZrrbE4tjg+o+Co0/Ub5TJ35OxuITF5UFtJpzu7CyAIq/j3kEnLKO9Vr7+G/Epu
 4+RqusNV8p0kqGkry51f4AVHOOqp7Kxm4oIMw4wM14Ircr0WWvsyylsJh2f4cXMYRFPp+14S0
 W1yOXufkUuYkCoPvLRpoknFVr3wJQ9xLJFw83lI2TQ9hW+Jx2s/tZQlYBUFwE9ZzpnZNIhn0s
 zgDEXwhXcycgCC6/4okINGMyRG0GZyw9Cy5d0PdQVHeaYARWM6+FfyfI6Yd7QJ/tYgcHmoGBq
 w3UDjgKw23wg/Wboe1FQMW2k6uudZ+FiB1fNVj07pW+j51SWACtNoPr3GGGDw/Wux2W0lp6Hr
 oEfmMb/zph2tA9lE
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sunday 11 October 2015 11:02:34 ygardi@codeaurora.org wrote:
> >
> > no need for the #ifdef here.
> 
> in include\scsi\scsi_host.h
> the hook - compat_ioctl is defined inside #ifdef CONFIG_COMPAT
> 
> #ifdef CONFIG_COMPAT
>         int (* compat_ioctl)(struct scsi_device *dev, int cmd, void __user *arg);
> #endif
> 
> 
> 

Ah, sorry about that. I saw your v4 before I saw this reply here, and
you are right. This is different from the normal file_operations
compat_ioctl method that doesn't need the #ifdef.

	Arnd