From: Jordan Crouse <jordan@cosmicpenguin.net>
To: Alessandro Zummo <azummo-lists@towertech.it>
Cc: "David Brownell" <david-b@pacbell.net>,
linux-geode@lists.infradead.org, dilinger@queued.net,
dsaxena@laptop.org, "Martin-Éric Racine" <q-funk@iki.fi>,
lkml <linux-kernel@vger.kernel.org>,
rpurdie@rpsys.net, "Ingo Molnar" <mingo@elte.hu>,
"Thomas Gleixner" <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] AMD Geode CS5535/5536 GPIO driver
Date: Sun, 15 Feb 2009 15:47:50 -0700 [thread overview]
Message-ID: <49989B96.7010604@cosmicpenguin.net> (raw)
In-Reply-To: <20090206101618.7102e46b@i1501.lan.towertech.it>
Alessandro Zummo wrote:
> On Thu, 5 Feb 2009 16:12:20 -0800
> David Brownell <david-b@pacbell.net> wrote:
>
>> Unless this hardware misbehaves when both output and input
>> modes are enabled (e.g. in the window between those two calls),
>> I'd suggest just not clearing INPUT_ENABLE. It's legit to
>> ask for the *actual* value of an output line, e.g. for when
>> it uses open drain mode. (And didn't this hardware have an
>> option for open drain GPIO signaling?)
>
> seems reasonable,
> I'll let the Geode people decide what to do here...
Sorry, I'm just getting around to answering this. I don't recall any
situation where the hardware would mis-behave, but you never know with
this bit of silicon.
I say leave them both on, and revisit it if you get flamed.
Jordan
next prev parent reply other threads:[~2009-02-15 22:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 15:10 [PATCH] AMD Geode CS5535/5536 GPIO driver Alessandro Zummo
2009-02-06 0:12 ` David Brownell
2009-02-06 9:16 ` Alessandro Zummo
2009-02-15 22:47 ` Jordan Crouse [this message]
2009-02-14 20:27 ` Andres Salomon
2009-02-14 22:02 ` Alessandro Zummo
2009-02-14 22:38 ` Andres Salomon
2009-02-14 22:54 ` Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49989B96.7010604@cosmicpenguin.net \
--to=jordan@cosmicpenguin.net \
--cc=azummo-lists@towertech.it \
--cc=david-b@pacbell.net \
--cc=dilinger@queued.net \
--cc=dsaxena@laptop.org \
--cc=hpa@zytor.com \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=q-funk@iki.fi \
--cc=rpurdie@rpsys.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox