From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756828AbZBPLuk (ORCPT ); Mon, 16 Feb 2009 06:50:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754106AbZBPLua (ORCPT ); Mon, 16 Feb 2009 06:50:30 -0500 Received: from homer.mvista.com ([63.81.120.155]:57467 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753827AbZBPLu3 (ORCPT ); Mon, 16 Feb 2009 06:50:29 -0500 Message-ID: <49995300.7030102@ru.mvista.com> Date: Mon, 16 Feb 2009 14:50:24 +0300 From: Sergei Shtylyov User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/18] ide: use ->tf_load in SELECT_DRIVE() References: <20080620213323.13202.71450.sendpatchset@localhost.localdomain> <20080620213451.13202.12671.sendpatchset@localhost.localdomain> <49987A37.9000300@ru.mvista.com> <4998AE87.3020502@ru.mvista.com> In-Reply-To: <4998AE87.3020502@ru.mvista.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, I wrote: >>> There should be no functional changes caused by this patch. >>> Signed-off-by: Bartlomiej Zolnierkiewicz >>> Index: b/drivers/ide/ide-iops.c >>> =================================================================== >>> --- a/drivers/ide/ide-iops.c >>> +++ b/drivers/ide/ide-iops.c >>> @@ -88,11 +88,15 @@ void SELECT_DRIVE (ide_drive_t *drive) >>> { >>> ide_hwif_t *hwif = drive->hwif; >>> const struct ide_port_ops *port_ops = hwif->port_ops; >>> + ide_task_t task; >>> >>> if (port_ops && port_ops->selectproc) >>> port_ops->selectproc(drive); >>> >>> - hwif->OUTB(drive->select.all, hwif->io_ports.device_addr); >>> + memset(&task, 0, sizeof(task)); >>> + task.tf_flags = IDE_TFLAG_OUT_DEVICE; >>> + >>> + drive->hwif->tf_load(drive, &task); >> >> This actually doesn't seem like a bright idea to me, considering >> that this gets called when starting every request. How will you look >> at me adding the transport method for writing this register? :-) > Convert SELECT_DRIVE() to use ->tf_load instead of ->OUTB. > > OTOH, adding such a "backdoor" to the taskfile doesn't seem very > consistent... well, I'm not excited about the whole idea conversion to > tf_{load|read}() -- it's not clear what exactly this bought us. We at least could have saved on memset() -- tf_load() method ignores fields other than tf_flags anyway... MBR, Sergei