From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757234AbZBPMZ4 (ORCPT ); Mon, 16 Feb 2009 07:25:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754551AbZBPMZr (ORCPT ); Mon, 16 Feb 2009 07:25:47 -0500 Received: from homer.mvista.com ([63.81.120.155]:58430 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752919AbZBPMZp (ORCPT ); Mon, 16 Feb 2009 07:25:45 -0500 Message-ID: <49995B44.6090604@ru.mvista.com> Date: Mon, 16 Feb 2009 15:25:40 +0300 From: Sergei Shtylyov User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/18] ide: use ->tf_read in ide_read_error() References: <20080620213323.13202.71450.sendpatchset@localhost.localdomain> <20080620213458.13202.77992.sendpatchset@localhost.localdomain> <4998A37D.3040904@ru.mvista.com> <49995856.0@ru.mvista.com> In-Reply-To: <49995856.0@ru.mvista.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, I wrote: >>> register and handle it in ->tf_read. >>> >> >> Doesn't seem like a good name -- you can't read the features >> register. I should've commented to this patch earlier, of course... > * Add IDE_TFLAG_IN_FEATURE taskfile flag for reading Feature > > Moreover, the error register shoudn't be affeceted by the HOB bit, > so this flag doesn't make sense. I meant IDE_TFLAG_IN_HOB_FEATURE, of course. MBR, Sergei