From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757426AbZBPNHo (ORCPT ); Mon, 16 Feb 2009 08:07:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755025AbZBPNHe (ORCPT ); Mon, 16 Feb 2009 08:07:34 -0500 Received: from hp3.statik.tu-cottbus.de ([141.43.120.68]:56102 "EHLO hp3.statik.tu-cottbus.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755021AbZBPNHd (ORCPT ); Mon, 16 Feb 2009 08:07:33 -0500 Message-ID: <4999650C.6030700@s5r6.in-berlin.de> Date: Mon, 16 Feb 2009 14:07:24 +0100 From: Stefan Richter User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.19) Gecko/20081204 SeaMonkey/1.1.14 MIME-Version: 1.0 To: Sam Ravnborg CC: Manish Katiyar , mingo@elte.hu, LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c References: <20090215184752.GA4970@uranus.ravnborg.org> In-Reply-To: <20090215184752.GA4970@uranus.ravnborg.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/15/2009 7:47 PM, Sam Ravnborg wrote: > On Mon, Feb 16, 2009 at 12:04:36AM +0530, Manish Katiyar wrote: >> Hi Ingo, >> >> I used your code-quality script to do cleanup in kernel/kallsyms.c. >> Below patch removes errors generated by checkpatch.pl. > When doing so use checkpatch only as a hint generator and do > not concentrate only on the warnings/errors generated by checkpatch. > > Your patch is an improvement but please fix the remaining issues. Furthermore, the changelog is bad (non-exiting in fact). The fact that the issues where discovered using checkpatch is absolutely uninteresting. The changelog should describe /what/ is fixed, e.g. whitespace, maybe other things. (In case of nontrivial changes the log may also need to explain not only the /what but also the /how/, but this does not apply to patches like this one.) -- Stefan Richter -=====-==--= --=- =---- http://arcgraph.de/sr/