From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754258AbZBPQfh (ORCPT ); Mon, 16 Feb 2009 11:35:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752286AbZBPQf1 (ORCPT ); Mon, 16 Feb 2009 11:35:27 -0500 Received: from hp3.statik.tu-cottbus.de ([141.43.120.68]:56700 "EHLO hp3.statik.tu-cottbus.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752251AbZBPQf0 (ORCPT ); Mon, 16 Feb 2009 11:35:26 -0500 Message-ID: <499995C4.3070504@s5r6.in-berlin.de> Date: Mon, 16 Feb 2009 17:35:16 +0100 From: Stefan Richter User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.19) Gecko/20081204 SeaMonkey/1.1.14 MIME-Version: 1.0 To: Julia Lawall CC: Ingo Molnar , Sam Ravnborg , Manish Katiyar , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c References: <20090215184752.GA4970@uranus.ravnborg.org> <4999650C.6030700@s5r6.in-berlin.de> <20090216132822.GC17996@elte.hu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Julia Lawall wrote: > Is everything below the --- preserved in what is available via git log? No, none of it (if the patch is mechanically applied with e.g. git-am). Sometimes, useful information does indeed get lost because an author didn't consider it "above ---"-worthy. ... > I think the how information has some value, > both to make people aware of what tools are useful for what kinds of > tasks, and to help one understand what criteria were used in making the > patch. That information is perfect for conservation mailing list archives. The source repository metadata (commit logs) have other purposes: Keep book about what happened to the source code and why. > This can sometimes be conveyed more precisely using code than > English text. If the scope of a change is better captured that way, then OK. > I agree that the how information is not always relevant for > the person who just wants to scan a changelog to see what is new in the > current Linux release. The changelog is not only to learn what's new (i.e. a source of release notes), it's also to learn what's old. :-) I go through old changelogs all the time because I deal with code with history older than my involvement or too old for me to remember the circumstances. -- Stefan Richter -=====-==--= --=- =---- http://arcgraph.de/sr/