From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755632AbZBPXDb (ORCPT ); Mon, 16 Feb 2009 18:03:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751400AbZBPXDU (ORCPT ); Mon, 16 Feb 2009 18:03:20 -0500 Received: from rtr.ca ([76.10.145.34]:37769 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751102AbZBPXDT (ORCPT ); Mon, 16 Feb 2009 18:03:19 -0500 Message-ID: <4999F0B8.7020700@rtr.ca> Date: Mon, 16 Feb 2009 18:03:20 -0500 From: Mark Lord Organization: Real-Time Remedies Inc. User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: Robert Hancock Cc: linux-kernel , ide , Jeff Garzik , Sergei Shtylyov , =?UTF-8?B?SGFubm8gQsO2Y2s=?= Subject: Re: [PATCH] libata: Don't trust current capacity values in identify words 57-58 References: <4999CA54.1060306@gmail.com> <4999F032.6060107@rtr.ca> In-Reply-To: <4999F032.6060107@rtr.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark Lord wrote: > Robert Hancock wrote: >> Hanno Böck reported a problem where an old Conner CP30254 240MB hard >> drive >> was reported as 1.1TB in capacity by libata: >> >> http://lkml.org/lkml/2009/2/13/134 >> >> This was caused by libata trusting the drive's reported current >> capacity in sectors in identify words 57 and 58 if the drive does not >> support LBA and the >> current CHS translation values appear valid. Unfortunately it seems older >> ATA specs were vague about what this field should contain and a number >> of drives >> used values with wrong byte order or that were totally bogus. There's no >> unique information that it conveys and so we can just calculate the >> number >> of sectors from the reported current CHS values. >> >> Signed-off-by: Robert Hancock > .. >> } else { >> if (ata_id_current_chs_valid(id)) >> - return ata_id_u32(id, 57); >> + return id[54] * id[55] * id[56]; >> else >> return id[1] * id[3] * id[6]; > .. > > NAK. That's not quite correct, either. > > The LBA capacity can be larger than the CHS capacity, > so we have to use the reported LBA values if at all possible. > > That's why ata_id_is_lba_capacity_ok() exists, > and why it looks so peculiar. > > Some of those early drives really did require that kind of logic. .. Mind you, one can do better than that, too. The "10% solution" in there right now is a bit of a (working) hack. It really probably just needs to check for a flipped-LBA that is within +/- one full cylinder of the CHS capacity. Cheers