From: Yinghai Lu <yinghai@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perfcounters/core] x86, apic: move APIC drivers to arch/x86/kernel/apic/*
Date: Tue, 17 Feb 2009 12:51:21 -0800 [thread overview]
Message-ID: <499B2349.1050006@kernel.org> (raw)
In-Reply-To: <20090217184110.GA331@elte.hu>
it seems you forgot to push it out.
YH
Ingo Molnar wrote:
> * Ingo Molnar <mingo@elte.hu> wrote:
>
>> * Yinghai Lu <yinghai@kernel.org> wrote:
>>
>>> could move probe_32.c es7000_32.c numaq_32.c summit_32.c to
>>> apic/ too
>> yeah, that's indeed the plan, just didnt get around testing that
>> yet.
>
> Below is the commit. Beyond what you listed, i moved bigsmp_32.c
> too. By renaming apic_64.c to probe_64.c we get the probing code
> mostly consolidated as well.
>
> Ingo
>
> ---------------->
>>From 2a05180fe2e5b414f0cb2ccfc80e6c90563e3c67 Mon Sep 17 00:00:00 2001
> From: Ingo Molnar <mingo@elte.hu>
> Date: Tue, 17 Feb 2009 20:35:16 +0100
> Subject: [PATCH] x86, apic: move remaining APIC drivers to arch/x86/kernel/apic/*
>
> Move the 32-bit extended-arch APIC drivers to arch/x86/kernel/apic/
> too, and rename apic_64.c to probe_64.c.
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
> arch/x86/kernel/Makefile | 6 +-----
> arch/x86/kernel/apic/Makefile | 9 +++++++--
> arch/x86/kernel/{ => apic}/bigsmp_32.c | 0
> arch/x86/kernel/{ => apic}/es7000_32.c | 0
> arch/x86/kernel/{ => apic}/numaq_32.c | 0
> arch/x86/kernel/{ => apic}/probe_32.c | 0
> arch/x86/kernel/apic/{apic_64.c => probe_64.c} | 0
> arch/x86/kernel/{ => apic}/summit_32.c | 0
> 8 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
> index 9139ff6..c70537d 100644
> --- a/arch/x86/kernel/Makefile
> +++ b/arch/x86/kernel/Makefile
> @@ -30,7 +30,7 @@ obj-y += traps.o irq.o irq_$(BITS).o dumpstack_$(BITS).o
> obj-y += time_$(BITS).o ioport.o ldt.o dumpstack.o
> obj-y += setup.o i8259.o irqinit_$(BITS).o
> obj-$(CONFIG_X86_VISWS) += visws_quirks.o
> -obj-$(CONFIG_X86_32) += probe_32.o probe_roms_32.o
> +obj-$(CONFIG_X86_32) += probe_roms_32.o
> obj-$(CONFIG_X86_32) += sys_i386_32.o i386_ksyms_32.o
> obj-$(CONFIG_X86_64) += sys_x86_64.o x8664_ksyms_64.o
> obj-$(CONFIG_X86_64) += syscall_64.o vsyscall_64.o
> @@ -70,10 +70,6 @@ obj-$(CONFIG_FUNCTION_GRAPH_TRACER) += ftrace.o
> obj-$(CONFIG_KEXEC) += machine_kexec_$(BITS).o
> obj-$(CONFIG_KEXEC) += relocate_kernel_$(BITS).o crash.o
> obj-$(CONFIG_CRASH_DUMP) += crash_dump_$(BITS).o
> -obj-$(CONFIG_X86_BIGSMP) += bigsmp_32.o
> -obj-$(CONFIG_X86_NUMAQ) += numaq_32.o
> -obj-$(CONFIG_X86_ES7000) += es7000_32.o
> -obj-$(CONFIG_X86_SUMMIT) += summit_32.o
> obj-y += vsmp_64.o
> obj-$(CONFIG_KPROBES) += kprobes.o
> obj-$(CONFIG_MODULES) += module_$(BITS).o
> diff --git a/arch/x86/kernel/apic/Makefile b/arch/x86/kernel/apic/Makefile
> index da20b70..97f558d 100644
> --- a/arch/x86/kernel/apic/Makefile
> +++ b/arch/x86/kernel/apic/Makefile
> @@ -2,14 +2,19 @@
> # Makefile for local APIC drivers and for the IO-APIC code
> #
>
> -obj-y := apic.o ipi.o nmi.o
> +obj-y := apic.o probe_$(BITS).o ipi.o nmi.o
> obj-$(CONFIG_X86_IO_APIC) += io_apic.o
> obj-$(CONFIG_SMP) += ipi.o
> +obj-$
>
> ifeq ($(CONFIG_X86_64),y)
> -obj-y += apic_64.o apic_flat_64.o
> +obj-y += apic_flat_64.o
> obj-$(CONFIG_X86_X2APIC) += x2apic_cluster.o
> obj-$(CONFIG_X86_X2APIC) += x2apic_phys.o
> obj-$(CONFIG_X86_UV) += x2apic_uv_x.o
> endif
>
> +obj-$(CONFIG_X86_BIGSMP) += bigsmp_32.o
> +obj-$(CONFIG_X86_NUMAQ) += numaq_32.o
> +obj-$(CONFIG_X86_ES7000) += es7000_32.o
> +obj-$(CONFIG_X86_SUMMIT) += summit_32.o
> diff --git a/arch/x86/kernel/bigsmp_32.c b/arch/x86/kernel/apic/bigsmp_32.c
> similarity index 100%
> rename from arch/x86/kernel/bigsmp_32.c
> rename to arch/x86/kernel/apic/bigsmp_32.c
> diff --git a/arch/x86/kernel/es7000_32.c b/arch/x86/kernel/apic/es7000_32.c
> similarity index 100%
> rename from arch/x86/kernel/es7000_32.c
> rename to arch/x86/kernel/apic/es7000_32.c
> diff --git a/arch/x86/kernel/numaq_32.c b/arch/x86/kernel/apic/numaq_32.c
> similarity index 100%
> rename from arch/x86/kernel/numaq_32.c
> rename to arch/x86/kernel/apic/numaq_32.c
> diff --git a/arch/x86/kernel/probe_32.c b/arch/x86/kernel/apic/probe_32.c
> similarity index 100%
> rename from arch/x86/kernel/probe_32.c
> rename to arch/x86/kernel/apic/probe_32.c
> diff --git a/arch/x86/kernel/apic/apic_64.c b/arch/x86/kernel/apic/probe_64.c
> similarity index 100%
> rename from arch/x86/kernel/apic/apic_64.c
> rename to arch/x86/kernel/apic/probe_64.c
> diff --git a/arch/x86/kernel/summit_32.c b/arch/x86/kernel/apic/summit_32.c
> similarity index 100%
> rename from arch/x86/kernel/summit_32.c
> rename to arch/x86/kernel/apic/summit_32.c
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-02-17 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-f62bae5009c1ba596cd475cafbc83e0570a36e26@kernel.org>
2009-02-17 18:10 ` [tip:perfcounters/core] x86, apic: move APIC drivers to arch/x86/kernel/apic/* Yinghai Lu
2009-02-17 18:18 ` Ingo Molnar
2009-02-17 18:41 ` Ingo Molnar
2009-02-17 20:51 ` Yinghai Lu [this message]
2009-02-17 21:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499B2349.1050006@kernel.org \
--to=yinghai@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox