Re: [PATCH] SMACK smacklabel : apply &MASK to IP inserted in /smack/netlabel

etienne
2009-02-18T07:25:48Z

Paul Moore wrote:
> On Tuesday 17 February 2009 03:32:15 pm etienne wrote:
>> ----
>> diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
>> index 8e42800..5717150 100644
>> --- a/security/smack/smackfs.c
>> +++ b/security/smack/smackfs.c
>> @@ -765,6 +765,7 @@ static ssize_t smk_write_netlbladdr(struct file *file,
>> const char __user *buf, mask.s_addr |= bebits;
>> bebits <<= 1;
>> }
>> + newname.sin_addr.s_addr &= mask.s_addr;
>> /*
>> * Only allow one writer at a time. Writes should be
>> * quite rare and small in any case.
>
> If you do this you can simplify some of the code in smack_host_label() by
> removing the code which applies the mask to the stored addresses when
> comparing addresses. There may be other places as well.
>
you're right, in mk_write_netlbladdr also, i'll have a look
thanks,
Etienne