From: Randy Dunlap <randy.dunlap@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andres Salomon <dilinger@debian.org>
Subject: [PATCH -mmotm] asiliantfb: fix ISO declaration/code warning
Date: Wed, 18 Feb 2009 11:12:54 -0800 [thread overview]
Message-ID: <499C5DB6.5010908@oracle.com> (raw)
In-Reply-To: <200902181018.n1IAISW7012483@imap1.linux-foundation.org>
From: Randy Dunlap <randy.dunlap@oracle.com>
Move data declaration before any code:
drivers/video/asiliantfb.c:515: warning: ISO C90 forbids mixed declarations and code
(from asiliantfb-fix-cmap-memory-leaks.patch)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/video/asiliantfb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- mmotm-2009-0218-0215.orig/drivers/video/asiliantfb.c
+++ mmotm-2009-0218-0215/drivers/video/asiliantfb.c
@@ -507,12 +507,13 @@ static struct fb_var_screeninfo asiliant
static int __devinit init_asiliant(struct fb_info *p, unsigned long addr)
{
+ int err;
+
p->fix = asiliantfb_fix;
p->fix.smem_start = addr;
p->var = asiliantfb_var;
p->fbops = &asiliantfb_ops;
p->flags = FBINFO_DEFAULT;
- int err;
err = fb_alloc_cmap(&p->cmap, 256, 0);
if (err) {
next parent reply other threads:[~2009-02-18 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200902181018.n1IAISW7012483@imap1.linux-foundation.org>
2009-02-18 19:12 ` Randy Dunlap [this message]
2009-02-18 19:34 ` [PATCH -mmotm] asiliantfb: fix ISO declaration/code warning Andres Salomon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499C5DB6.5010908@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dilinger@debian.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox