From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Zachary Amsden <zach@vmware.com>
Cc: Ingo Molnar <mingo@elte.hu>,
the arch/x86 maintainers <x86@kernel.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Nick Piggin <npiggin@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Rusty Russell <rusty@rustcorp.com.au>,
Alok Kataria <akataria@vmware.com>, Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Subject: Re: [PATCH 3/9] x86/paravirt: remove lazy mode in interrupts
Date: Wed, 18 Feb 2009 16:17:20 -0800 [thread overview]
Message-ID: <499CA510.2040406@goop.org> (raw)
In-Reply-To: <1235004837.6951.6.camel@bodhitayantram.eng.vmware.com>
Zachary Amsden wrote:
> On Wed, 2009-02-18 at 14:30 -0800, Jeremy Fitzhardinge wrote:
>
>> From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
>>
>> Make paravirt_lazy_mode() always return PARAVIRT_LAZY_NONE
>> when in an interrupt. This prevents interrupt code from
>> accidentally inheriting an outer lazy state, and instead
>> does everything synchronously. Outer batched operations
>> are left deferred.
>>
>
> This looks like a good solution, but can you make paravirt_lazy_mode()
> inline? It doesn't need to be a function call.
Yeah. I'm not quite sure why it became out of line.
J
next prev parent reply other threads:[~2009-02-19 0:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 22:30 [PATCH 0/9] *** SUBJECT HERE *** Jeremy Fitzhardinge
2009-02-18 22:30 ` [PATCH 3/9] x86/paravirt: remove lazy mode in interrupts Jeremy Fitzhardinge
2009-02-19 0:53 ` Zachary Amsden
2009-02-19 0:17 ` Jeremy Fitzhardinge [this message]
2009-02-18 22:30 ` [PATCH 4/9] x86/pvops: replace arch_enter_lazy_cpu_mode with arch_start_context_switch Jeremy Fitzhardinge
2009-02-18 22:30 ` [PATCH 5/9] x86/paravirt: flush pending mmu updates on context switch Jeremy Fitzhardinge
2009-02-18 22:30 ` [PATCH 6/9] x86/paravirt: allow preemption with lazy mmu mode Jeremy Fitzhardinge
2009-02-18 22:30 ` [PATCH 7/9] mm: allow preemption in apply_to_pte_range Jeremy Fitzhardinge
2009-02-18 22:30 ` [PATCH 8/9] x86/paravirt: use percpu_ rather than __get_cpu_var Jeremy Fitzhardinge
2009-02-18 22:30 ` [PATCH 9/9] x86/paravirt: finish change from lazy cpu to context switch start/end Jeremy Fitzhardinge
2009-02-18 22:36 ` [PATCH 0/9] Make lazy mmu update mode pre-empt safe Andrew Morton
2009-02-18 22:43 ` Jeremy Fitzhardinge
2009-02-18 22:52 ` Jeremy Fitzhardinge
2009-02-18 22:55 ` Ingo Molnar
2009-02-18 23:04 ` Jeremy Fitzhardinge
2009-02-18 23:13 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499CA510.2040406@goop.org \
--to=jeremy@goop.org \
--cc=akataria@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mtosatti@redhat.com \
--cc=npiggin@suse.de \
--cc=peterz@infradead.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox