public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Paul Menage <menage@google.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpuset: various documentation fixes and updates
Date: Thu, 19 Feb 2009 13:41:32 +0800	[thread overview]
Message-ID: <499CF10C.1010104@cn.fujitsu.com> (raw)
In-Reply-To: <499CED75.9030907@oracle.com>

>>  If a cpuset has its 'cpus' modified, then each task in that cpuset
>>  will have its allowed CPU placement changed immediately.  Similarly,
>> -if a tasks pid is written to a cpusets 'tasks' file, in either its
>> -current cpuset or another cpuset, then its allowed CPU placement is
>> -changed immediately.  If such a task had been bound to some subset
>> -of its cpuset using the sched_setaffinity() call, the task will be
>> -allowed to run on any CPU allowed in its new cpuset, negating the
>> -affect of the prior sched_setaffinity() call.
>> +if a tasks pid is written to another cpusets 'tasks' file, then its
> 
>         task's pid                      cpuset's
> 

Paul Jackson is the original author of this document, and he once said he
doesn't like to use foo's but is used to use foos, so I think I'm not
going to correct them all through this doc, at least not in this patch. :)

>> +allowed CPU placement is changed immediately.  If such a task had been
>> +bound to some subset of its cpuset using the sched_setaffinity() call,
>> +the task will be allowed to run on any CPU allowed in its new cpuset,
>> +negating the affect of the prior sched_setaffinity() call.
> 
>                 effect
> 

Will fix.

>> + - via the cpuset file system directly, using the various cd, mkdir, echo,
>> +   cat, rmdir commands from the shell, or there equivalent from C.
> 
>                                              their

Will fix.

>> -mount -t cgroup -ocpuset X /dev/cpuset
>> +mount -t cgroup -ocpuset,noprefix X /dev/cpuset
> 
> I'm used to "-o options_list"... I guess either is OK.
> 

Actually I'm used to "-o opt" too.

Thanks for the review!



  reply	other threads:[~2009-02-19  5:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-19  2:11 [PATCH] cpuset: various documentation fixes and updates Li Zefan
2009-02-19  5:26 ` Randy Dunlap
2009-02-19  5:41   ` Li Zefan [this message]
2009-02-19  5:46     ` Randy Dunlap
2009-02-19  5:54       ` Li Zefan
2009-02-19  5:58     ` [PATCH -v2] " Li Zefan
2009-02-19 16:23       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499CF10C.1010104@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox