* [PATCH] staging: ! x & y problem in inactive code
@ 2009-02-19 10:36 Roel Kluin
2009-02-25 6:00 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-02-19 10:36 UTC (permalink / raw)
To: Greg KH; +Cc: lkml, Andrew Morton
This is the only ! x & y problem I found that weren't already reported,
except by me in http://lkml.org/lkml/2009/1/17/69 but maybe you
overlooked it?
It's in comment, but maybe this was the reason why it was commented out to
begin with?
Gr,
Roel
--------------------------->8-------------8<------------------------------
Fix ! x & y problem in inactivated code
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
index 9453495..18a7bad 100644
--- a/drivers/staging/rtl8187se/r8180_core.c
+++ b/drivers/staging/rtl8187se/r8180_core.c
@@ -3161,7 +3161,7 @@ void rtl8180_prepare_beacon(struct net_device *dev)
return ;
}
- //while(! *tail & (1<<31)){
+ //while(! (*tail & (1<<31))){
*tail= 0; // zeroes header
*tail = *tail| (1<<29) ; //fist segment of the packet
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: ! x & y problem in inactive code
2009-02-19 10:36 [PATCH] staging: ! x & y problem in inactive code Roel Kluin
@ 2009-02-25 6:00 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2009-02-25 6:00 UTC (permalink / raw)
To: Roel Kluin; +Cc: Greg KH, lkml, Andrew Morton
On Thu, Feb 19, 2009 at 11:36:41AM +0100, Roel Kluin wrote:
> This is the only ! x & y problem I found that weren't already reported,
> except by me in http://lkml.org/lkml/2009/1/17/69 but maybe you
> overlooked it?
Sorry, got it now, they should all be fixed up, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-25 6:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-19 10:36 [PATCH] staging: ! x & y problem in inactive code Roel Kluin
2009-02-25 6:00 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox