Re: [PATCH] x86: enable x2apic early at the first point

[Yinghai Lu <yinghai@kernel.org>]

Suresh Siddha wrote:
> On Thu, 2009-02-19 at 13:50 -0800, Yinghai Lu wrote:
>> Impact: fix bug.
>>
>> otherwise will get panic from early_acpi_boot_init()
>> also make disable_x2apic global, so could use it it x2_apic_xxx.c
>> and can get warning if preenabled system using nox2apic.
>>
>> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>>
>> ---
>>  arch/x86/kernel/apic/apic.c           |    3 +--
>>  arch/x86/kernel/apic/x2apic_cluster.c |    5 ++++-
>>  arch/x86/kernel/apic/x2apic_phys.c    |    5 ++++-
>>  arch/x86/kernel/apic/x2apic_uv_x.c    |    4 +++-
>>  drivers/pci/dmar.c                    |    3 ++-
>>  5 files changed, 14 insertions(+), 6 deletions(-)
>>
>> Index: linux-2.6/arch/x86/kernel/apic/x2apic_cluster.c
>> ===================================================================
>> --- linux-2.6.orig/arch/x86/kernel/apic/x2apic_cluster.c
>> +++ linux-2.6/arch/x86/kernel/apic/x2apic_cluster.c
>> @@ -14,8 +14,11 @@ DEFINE_PER_CPU(u32, x86_cpu_to_logical_a
>>
>>  static int x2apic_acpi_madt_oem_check(char *oem_id, char *oem_table_id)
>>  {
>> -       if (cpu_has_x2apic)
>> +       if (cpu_has_x2apic && !disable_x2apic) {
>> +               x2apic = 1;
>> +               enable_x2apic();
> 
> Yinghai, I also ran into couple of x2apic issues on the latest tip and
> this issue is one of them. I don't like this patch mainly because we are
> enabling x2apic mode in the cpu, with out checking the intr-remapping
> support. We should fall back to xapic mode (in a clean fashion) if there
> is any issue with intr-remapping. So I am planning to post another patch
> to fix this early hang issue that we both encountered.

Ingo want to decouple that x2apic and intr_remapping.
it seems it does work with x2apic without intr_remapping in one of setup.

YH